Closed
Bug 947356
Opened 10 years ago
Closed 10 years ago
On a dark/black toolbar, icons are too dark, need lighter color for more contrast (inverted icons?).
Categories
(Firefox :: Theme, defect)
Tracking
()
People
(Reporter: Aleksej, Assigned: dao)
References
(Depends on 1 open bug, Blocks 2 open bugs)
Details
(Keywords: regression)
Attachments
(2 files)
70.41 KB,
image/png
|
Details | |
4.14 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
2013-12-06-03-02-02-mozilla-central-firefox-28.0a1.en-US.linux-x86_64 The screenshots were made with a "Shiki" GTK theme. The zoom control is text, so it is a separate issue (it works with Darklooks).
Comment 1•10 years ago
|
||
Which icons do you mean? The tabscrolling and tab list dropdown icons, or something else? In the screenshot, it seems all other icons are inverted...
Flags: needinfo?(deletesoftware+moz)
Reporter | ||
Comment 2•10 years ago
|
||
I think the "+", "−" and wrench icons are not inverted: they look wrong.
Flags: needinfo?(deletesoftware+moz)
Comment 4•10 years ago
|
||
I think this is basically unsolvable (for now) - no matter what icon color/inversion we use, there will be some GTK theme that matches it closely enough that it becomes low-contrast. The long-term solution would be to use SVG icons so we can dynamically adjust the color of icons, but that's not going to happen soon.
Flags: needinfo?(shorlander)
Whiteboard: [testday-20131206] → [testday-20131206][Australis:P-]
Assignee | ||
Comment 5•10 years ago
|
||
Bug 764299 should have made SVG icons viable. What else is missing?
Assignee | ||
Updated•10 years ago
|
Component: Toolbars and Customization → Theme
Comment 6•10 years ago
|
||
I believe at least part of the problem was that it seemed like introducing SVG icons would regress us on ts_paint. I wonder if it's possible to persist the cached SVG from session to session, and only invalidate it if we detect a system theme change?
Comment 7•10 years ago
|
||
How does using SVG fix the part where we need to determine the background color in order to pick colors for the icons?
Comment 8•10 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #7) > How does using SVG fix the part where we need to determine the background > color in order to pick colors for the icons? It would cover the system theme case because we have corresponding system to choose from. e.g. -moz-appearance:menubar / background-color: -moz-MenuBarText So we wouldn't have to determine anything.
Flags: needinfo?(shorlander)
Assignee | ||
Updated•10 years ago
|
Blocks: 874674
Keywords: regression
Assignee | ||
Comment 9•10 years ago
|
||
After bug 994623 and bug 637608, the all tabs button is the remaining affected piece. Images and CSS adopted from the Windows theme.
Assignee | ||
Comment 10•10 years ago
|
||
Marco, could you please add this to the current iteration?
Points: --- → 2
Flags: needinfo?(mmucci)
Whiteboard: [testday-20131206][Australis:P-] → [qa+]
Comment 11•10 years ago
|
||
Added to Iteration 33.1
Points: 2 → ---
Flags: needinfo?(mmucci)
Whiteboard: [qa+] → p=2 s=33.1 [qa+]
Updated•10 years ago
|
Iteration: --- → 33.2
Points: --- → 2
QA Whiteboard: [qa+]
Whiteboard: p=2 s=33.1 [qa+]
Updated•10 years ago
|
Flags: firefox-backlog+
Updated•10 years ago
|
QA Contact: cornel.ionce
Comment 12•10 years ago
|
||
Comment on attachment 8443577 [details] [diff] [review] remaining piece: the all tabs button Review of attachment 8443577 [details] [diff] [review]: ----------------------------------------------------------------- Alright, looks good to me! Thanks Dão. Apology for the review delay... many things on my plate atm.
Attachment #8443577 -
Flags: review?(mdeboer) → review+
Assignee | ||
Comment 13•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/4125eff7a185
Comment 14•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4125eff7a185
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Comment 15•10 years ago
|
||
Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0 Verified this issue as fixed using latest Firefox Nightly, build ID: 20140629030206 on Ubuntu 13.04 64bit.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
You need to log in
before you can comment on or make changes to this bug.
Description
•