Closed
Bug 948001
Opened 11 years ago
Closed 11 years ago
[Settings] With APZ turned on the wifi panel is sometimes shown instead of the main panel at startup
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(blocking-b2g:1.3+, b2g-v1.3 fixed)
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
Attachments
(1 file, 1 obsolete file)
2.37 KB,
patch
|
arthurcc
:
review+
|
Details | Diff | Splinter Review |
Seems like there is a race here. The app starts with a viewport of 968px and then is resize to device-width. But this is too late since the rotate callback has already fired and start to load the wifi panel.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8344757 -
Flags: review?(arthur.chen)
Comment 2•11 years ago
|
||
Comment on attachment 8344757 [details] [diff] [review] Delay a bit the rotation listener Review of attachment 8344757 [details] [diff] [review]: ----------------------------------------------------------------- ::: apps/settings/js/settings.js @@ +800,4 @@ > console.log('go to default Panel ' + Settings.defaultPanelForTablet); > Settings.currentPanel = Settings.defaultPanelForTablet; > } > + We need to set ScreenLayout (calling to watch) before calling to Settings.isTabletAndLandscape() in which we get layout information from ScreenLayout.
Attachment #8344757 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 3•11 years ago
|
||
Is it better ?
Attachment #8344757 -
Attachment is obsolete: true
Attachment #8345235 -
Flags: review?(arthur.chen)
Comment 4•11 years ago
|
||
Comment on attachment 8345235 [details] [diff] [review] bug909877.patch r=me. Thanks!
Attachment #8345235 -
Flags: review?(arthur.chen) → review+
Assignee | ||
Comment 5•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/d1f2320d77bca838ecf560e7ce5bca43c28e887e This patch needs to land on 1.3.
Status: NEW → RESOLVED
blocking-b2g: --- → 1.3+
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Blocks: gaia-apzc-2
Updated•11 years ago
|
No longer blocks: gaia-apzc-2
Assignee | ||
Comment 7•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/46b682ae19fb8679542ea1714ccb5384f5bdaa84 Pushed in 1.3.
Updated•11 years ago
|
status-b2g-v1.3:
--- → fixed
Updated•10 years ago
|
Assignee: nobody → 21
You need to log in
before you can comment on or make changes to this bug.
Description
•