948040 - Back out the download manager from 1.3

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Jason Smith [:jsmith]]

Per today's go/no go discussion, we've decided to pref off the download manager on 1.3. When 1.3 branches, we should prep & land a patch to pref off the download manager on 1.3.

Comment 1

[Marcelino Veiga Tuimil [:sonmarce]]

If I understood well what we agreed yesterday was to back out everything from 1.3 branch instead of pref off

Comment 2

[Jason Smith [:jsmith]]

(In reply to Marcelino Veiga Tuimil [:sonmarce] from comment #1)
> If I understood well what we agreed yesterday was to back out everything
> from 1.3 branch instead of pref off

Yeah, back out is right if it can be done cleanly. Let me fix the bug title to reflect that.

Comment 3

[Marcelino Veiga Tuimil [:sonmarce]]

Just one more thing, back out of API implementation is the most important thing, because it will start downloads even if no UI is present

Comment 4

[[:fabrice] Fabrice Desré]

There's no need to backout everything. But we know what to do...

Comment 5

[Aus Lacroix [:aus]]

Really? We can simply turn off the API with a pref. Aren't the hooks in Gaia something we can key off of the same pref?

Comment 6

[[:fabrice] Fabrice Desré]

(In reply to Ghislain 'Aus' Lacroix from comment #5)
> Really? We can simply turn off the API with a pref. Aren't the hooks in Gaia
> something we can key off of the same pref?

That would need a pref <-> setting bridge. I'm not a fan of doing that here, but I'll defer to Gregor.

Comment 7

[Aus Lacroix [:aus]]

True, that's not ideal. Maybe we pref-off the API itself which is clean and easy to do and back-out the Gaia bits only?

Comment 8

[[:fabrice] Fabrice Desré]

(In reply to Ghislain 'Aus' Lacroix from comment #7)
> True, that's not ideal. Maybe we pref-off the API itself which is clean and
> easy to do and back-out the Gaia bits only?

I would prefer that, yes.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Backout from 1.3 branch

This backout has been done reverting 23 commits in order related to DM.

No conflicts during the reverts. Please verify the content.

Comment 10

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8348649 [details] [review]
Backout from 1.3 branch

It looks good. I've checked all changes in shared and system what I did and all of them were reverted successfully. Bye download manager

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Guys previously you can find the backout from gaia. Finally was pretty straight forward. What will be the final solution for the API side?

Cheers,
F.

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Sorry forgot to add a needinfo for my previous comment.

Comment 13

[Gregor Wagner [:gwagner]]

Comment on attachment 8348649 [details] [review]
Backout from 1.3 branch

Thanks!

Comment 14

[Julien Wajsberg [:julienw]]

Comment on attachment 8348649 [details] [review]
Backout from 1.3 branch

Tried it on the phone, the notification part still works, so I'm happy ;)

Comment 15

[Evelyn Hung]

Comment on attachment 8348649 [details] [review]
Backout from 1.3 branch

thanks!

Comment 16

[Francisco Jordano [:arcturus] [:francisco]]

Quick question John, should I merge, this against 1.3 or you will do it?

Comment 17

[Julien Wajsberg [:julienw]]

Just do it Francisco :)
(don't know why you're not assignee)

Comment 18

[Francisco Jordano [:arcturus] [:francisco]]

@Julien, cause we still need the gecko backout/setting solution in gecko ;)

Comment 19

[Francisco Jordano [:arcturus] [:francisco]]

Landed in v1.3:

https://github.com/mozilla-b2g/gaia/commit/1594923a1f1eb6f86da7fa8087532f58479773a5

Now waiting for the api solution to close this bug.

Comment 20

[Jason Smith [:jsmith]]

This shouldn't be marked fixed yet - we need to land a fix on the gecko side to back out/pref off the download API.

Comment 21

[Marcelino Veiga Tuimil [:sonmarce]]

Well, Gaia part is fixed, remaining part not yet landed is Gecko part, and as far as I know it requires a different status flag.

Comment 22

[Jason Smith [:jsmith]]

(In reply to Marcelino Veiga Tuimil [:sonmarce] from comment #21)
> Well, Gaia part is fixed, remaining part not yet landed is Gecko part, and
> as far as I know it requires a different status flag.

Ah right. status-firefox28 would track that.

Comment 23

[[:fabrice] Fabrice Desré]

Attachment: gecko patch

Comment 24

[Aus Lacroix [:aus]]

Comment on attachment 8350221 [details] [diff] [review]
gecko patch

Review of attachment 8350221 [details] [diff] [review]:
-----------------------------------------------------------------

See you in 1.4 Downloads API!

Comment 25

[[:fabrice] Fabrice Desré]

Comment on attachment 8350221 [details] [diff] [review]
gecko patch

Review of attachment 8350221 [details] [diff] [review]:
-----------------------------------------------------------------

I want to do it a bit differently.

Comment 26

[[:fabrice] Fabrice Desré]

I went with a full backout:
https://hg.mozilla.org/releases/mozilla-aurora/rev/e7079364d19b

Comment 27

[Jason Smith [:jsmith]]

Closing this out as we've now backed this out in gecko & gaia.