94831 - convert mozilla/intl/locale/src/nsLocalModule to generic module

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P1)

Description

[Chris Waterson]

Need to convert this to a generic module to get static build to work right.

Comment 1

[Chris Waterson]

Attachment: clean up locale stuff on Unix

Comment 2

[Chris Waterson]

I removed nsLocaleFactoryUnix.[h|cpp], and replaced the ad hoc module
implementation in nsLocaleModule.cpp with generic module stuff.

ftang, please review, or find somebody to review -- thanks!

Comment 3

[Chris Waterson]

I should note that the above patch was made against MOZILLA_0_9_2_BRANCH. I'll
attach a patch for the trunk shortly.

Comment 4

[Simon Fraser [no longer active]]

See also bug 93566 for mac

Comment 5

[Chris Waterson]

Attachment: also need to fix Win32

Comment 6

[Chris Waterson]

For this to work, we need to apply attachment 45489 [details] [diff] [review] (for Unix), attachment 
45746 [details] [diff] [review] (for Windows), and attachment 45703 [details] [diff] [review] from bug 93556 (for Mac).

Comment 7

[Chris Waterson]

...sorry, bug 93566 for Mac.

Comment 8

[Frank Tang]

I feel so embarssed that we stil have this code here. Thanks waterson, I should 
buy you a lunch for doing this for us....

r=ftang

Comment 9

[Chris Waterson]

Okay, so the above patch is not sufficient. Whoever wrote the COM glue for the
locale module was very...creative. I'm going to need to rewrite most of it. *sob*

Comment 10

[Chris Waterson]

*** Bug 93566 has been marked as a duplicate of this bug. ***

Comment 11

[Chris Waterson]

Attachment: clean up locale a bit

Comment 12

[Chris Waterson]

Okay, here's what I did.

- The old locale that tague (?) wrote had hand-coded factories for
  every class. I replaced those with generic factories as best I could.

- Along those lines, got rid of ns[IWin32|Mac|OS2|Posix]LocaleFactory.[h|cpp],
  which are not needed. (Actually, still need to do OS2, ...)

- I removed the nsI[IWin32|Mac|OS2|Posix]Locale.h interfaces (which were
  all identical), and replaced them with nsIPlatformLocale.

- Got rid of ns[I]LocalFactory.[h|cpp], as it was obsolete (assertions in
  the ctor).

- Normalized nsLocale[DLL|Module|SHLIB].cpp to use generic factory stuff

- Got rid of hard-coded CIDs and IIDs where reasonable.

Still need to test on Mac and Win32. Could use some help on OS/2 also.

Comment 13

[Mike Kaply [:mkaply]]

I'm having trouble applying the diff. I'll look at it though.

Comment 14

[Chris Waterson]

Attachment: first crack at OS/2, add some fixes for Mac and Win32

Comment 15

[Simon Fraser [no longer active]]

What user actions excercise this code?

Comment 16

[Chris Waterson]

Well, I get some assertions at startup if it's wrong, but I have _no_ idea what
it does or where it is being used.

Comment 17

[Chris Waterson]

Attachment: another attempt

Comment 18

[Chris Waterson]

Okay, so it turns out that nsI[Mac|OS2|Posix|Win32]Locale are all subtly
different in mysterious ways. So, I've put those interfaces back the way they were.

The above patch compiles and runs on Unix and Windows, makes it at least through
the intl folder on Mac, and has an honest attempt at getting this right on OS/2.
If there are any other nits that I got wrong on the Mac side, I'll attach them
anon as my build progresses.

Comment 19

[Chris Waterson]

I crash-landed this onto the trunk tonight.

Comment 20

[Chris Waterson]

Attachment: static build fixes for Win32

Comment 21

[Myk Melez [:myk] [@mykmelez]]

Fixing database corruption caused by bug 95743.  Pay no attention to the man
behind the curtain.

Comment 22

[Chris Waterson]

Attachment: up-to-date patch for MOZILLA_0_9_2_BRANCH

Comment 23

[Mike Kaply [:mkaply]]

Chris,

Does you branch patch have the os/2 bustage fixes you did in it?

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&su
bdir=mozilla/intl/locale/src/os2&command=DIFF_FRAMESET&file=nsLocaleModule.cpp&r
ev1=1.8&rev2=1.9&root=/cvsroot

Comment 24

[Chris Waterson]

mkaply: yes, it should. I hand-merged files from the trunk, and hopefully caught
everything. When (if?) I land these, would you mind if I ping'd you to do a build?

Comment 25

[Andreas Becker]

Switching qa contact to teruko for now since it is a topembed bug.  Please
re-assign further as you see is appropriate.

Comment 26

[Marek Z. Jeziorek]

let's get it on 0.9.2 branch. thanks

Comment 27

[Roy Yokoyama]

changing qa contact to yokoyama since it is a coding modification.

Comment 28

[Chris Waterson]

Checked in on the branch.