94873 - Using cert "Backup All" breaks cert import.

Status: VERIFIED WORKSFORME

(Core Graveyard :: Security: UI, defect, P2)

Description

[Stephane Saux]

To reproduce:
create a new profile.
Import a cert (software device)
Use backup all
delete the cert.
Import the file used in the backup all step.

Expected: the cert is restored.
Actual: Get "Failed to restore your cert for unknown reasons"

Javi.  Actually, the problem may not be with the backup all functionality but
rather with the "delete" then "restore" sequence.

I.e., the simplest, minimal test case may be:
new profile.
import a cert.
delete the cert.
import the cert again.

I'll update the bug to confirm when I restart this instance of the browser.

Comment 1

[Stephane Saux]

P1
t->2.1
nsenterprise.
The simplest test case is indeed to import a p12, delete the resulting cert, and
importing the same p12.

Comment 2

[Javier Delgadillo]

This is caused by us leaking a reference to an NSS certificate somewhere.  It
turns out PSM2 doesn't notify when the cert already exists in the db.  I'll add
code to say "Cert and private key already exist" and I'll track down the cert
leak.  

Comment 3

[Stephane Saux]

Target->future.
Adding relnote keyword. This only happens if you delete the cert you just
exported and then import it again.  This is the kind of thing one would do while
testing backup/restore, but not something a normal user is likely to do. Note
that the cert can be imported after quitting the application. This can be relnoted.
-> rangansen since javi goes on sabbatical.

Comment 4

[Javier Delgadillo]

Attachment: Patch of what I had up to now..

Comment 5

[Javier Delgadillo]

This attached patch will tell the user: "This cert and private key already
exists in your database."

It won't make the the restore successful, but it's a more useful error message
in this case.

Comment 6

[Stephane Saux]

*** Bug 99190 has been marked as a duplicate of this bug. ***

Comment 7

[John Unruh]

WFM with the 9/19 Win2000 trunk build.

Comment 8

[John Unruh]

Verified.