949021 - [Unagi_1.2][Pre-IOT] Contact's name not showed when receiving SMS class 0

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[David Palomino [:dpalomino]]

Issue detected during pre-IOT for 1.2

Gecko: d77ba08
Gaia: 1b67b55
AU: AU_LINUX_GECKO_B2G_ICS_1.2.01.02.00.019.120

When receiving a SMS class 0, contact's name is not detected, even though it's stored in Contacts. MSISDN is showed instead. 

However, I think it is not a blocker issue for 1.2, as these messages are not typically sent by users but by operators or third companies, so it's not likely the user to have this contact stored.

Comment 1

[Julien Wajsberg [:julienw]]

I confirm that we just output the "number" without checking a match in the contact list, when we receive a class-0 SMS.

Should we really fix this eventually? Adding complexity for an edge case?

Comment 2

[promise09th]

Attachment: Pull Request URL #16584

Comment 3

[promise09th]

Comment on attachment 8380988 [details]
Pull Request URL #16584

I made a simple patch.
Can you check this patch?

Thanks

Comment 4

[Rick Waldron [:rwaldron]]

Can you add a test for this?

Comment 5

[Julien Wajsberg [:julienw]]

I'm not sure we want to fix this actually.

Ayman, what do you think?

Comment 6

[ayman maat :maat]

(In reply to Julien Wajsberg [:julienw] from comment #5)
> I'm not sure we want to fix this actually.
> 
> Ayman, what do you think?

Hi julien, I checked with TEF and we should pick up the name from the contact list if the number is stored in the contact list. Therefore this should be fixed and we should aim for v1.5

Comment 7

[Julien Wajsberg [:julienw]]

Thanks, then I'll move forward with the review :)

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 8380988 [details]
Pull Request URL #16584

This looks good but we need unit tests for this.

There is a activity_handler_test.js file where you can add a test.

There is a suite "receive class-0 message" that you can update, inspiring from the suites "contact retrieved (after getSelf)" and "contact without name (after getSelf)" to see how they manage to fake retrieving contacts.

Thanks a lot for your patch!

Comment 9

[Julien Wajsberg [:julienw]]

Needs someone to pick up the work that's already done here and finish it doing some unit tests.

Comment 10

[Julien Wajsberg [:julienw]]

This bug is still current.

Comment 11

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 12

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(