949315 - Travis unit test failure on v1.2: initGridManager is not defined

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I saw every build on v1.2 failed on this,

--
  1) [homescreen] everything.me.js > Everything.me is displayed > grid.js > onInstall event dispatch before SingleVariant will be ready > Dispatch onInstall before SingleVariant is been ready "before each" hook:
     ReferenceError: initGridManager is not defined
      at (anonymous) (http://homescreen.gaiamobile.org:8080/test/unit/grid_test.js:464)
      at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:60)
      at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
      at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973)
      at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)
      at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

example: https://travis-ci.org/mozilla-b2g/gaia/builds/15310800

Comment 2

[Cristian Rodriguez (:crdlc)]

Carmen, could it be for something related to single variant? Thanks a lot

Comment 3

[Carmen Jimenez Cabezas]

I'll take a look at it

Comment 4

[Carmen Jimenez Cabezas]

Attachment: Proposed patch v1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
944495
[User impact] if declined:
none
[Testing completed]:
yes
[Risk to taking this patch] (and alternatives if risky):
very low
[String changes made]:
Fixed unit test on homescreen/grid_test.js

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8347297 [details] [review]
Proposed patch v1

Thanks a lot Carmen. Just a question, could it happen on master and v1.3 as well?

Comment 6

[Carmen Jimenez Cabezas]

No, this was just a left over from the uplift of bug 925461 to 1.2

Comment 7

[Carmen Jimenez Cabezas]

Merged:
https://github.com/mozilla-b2g/gaia/commit/3f2550c2fabea0f16e9c743093c4b61103a8dba8