949459 - Recent changes to gaiatest atoms cause JavascriptException: TypeError: window.wrappedJSObject.WindowManager when running across branches

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Packages like b2gperf depend on gaiatest, which includes the JavaScript atoms. These have recently been updated for the AppWindowManager changes, but this means that the distributed version of gaiatest is now only compatible with the master branch.

As we run these tests against multiple branches, we should add backwards compatibility to the atoms at least until branches are no longer supported.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14613

Pointer to Github pull-request

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8346552 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14613

This fixes it for me. Mind giving a review, Alive?

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8346552 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14613

If this works for you I definitely should give r+

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed in:
https://github.com/mozilla-b2g/gaia/commit/d9dd00fa4b67c6965fd0787301225edf6b1ec120 (master)

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4db67fde4d6c