949613 - Scrolled off title-bar is shown when prior it is hidden after an action or dismissal of use of the text-selection action-bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Aaron Train [:aaronmt]]

Not sure if this is intentional.

Currently when the text-selection action-bar is dismissed, the title bar is shown. If we show the text-action action-bar coming from a title-bar is hidden state, on dismissal I would have expected to see the title-bar remain hidden.

Steps to reproduce:

i) Visit http://www.lipsum.com/feed/html 
ii) Scroll down to hide the title-bar
iii) Do a text-selection, and then dismiss it or perform an action on the selected text

Expected: Title-bar remains hidden
Actual: Title-bar is revealed again afterwards

--
Nightly|Aurora (12/12), LG Nexus 4 (Android 4.4.2)

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Ian, what do you want the behavior to be here?

Comment 2

[Ian Barlow (:ibarlow)]

Aaron's right, the title bar should remember and return to its state before action mode was launched.

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch v1

This is the simplest way to do this.

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 8358688 [details] [diff] [review]
Patch v1

Review of attachment 8358688 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok. It would be nice if we could factor out the dynamic toolbar / action mode logic into a separate/reusable class.

::: mobile/android/base/BrowserApp.java
@@ +2589,1 @@
>          mViewFlipper.showPrevious();

nit: add empty line here.

@@ +2589,5 @@
>          mViewFlipper.showPrevious();
> +        // Only slide the urlbar out if it was hidden when the action mode started
> +        // Don't animate hiding it so that there's no flash as we switch back to url mode
> +        if (mShowActionModeEndAnimation) {
> +            margins.hideMargins(true);

Don't you ever need to reset mShowActionModeEndAnimation to false after using it?

Comment 5

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/94dcc39391bc

Comment 6

[Wesley Johnston (:wesj)]

Comment on attachment 8358688 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 768667
User impact if declined: Titlebar scrolls on automatically but has to be manually scrolled off
Testing completed (on m-c, etc.): landing soon
Risk to taking this patch (and alternatives if risky): Pretty low risk, but we could leave things as is with minimal effect on users.
String or IDL/UUID changes made by this patch: None.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Triage drive-by: waiting for this to get to Nightly from project branch.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

I'm not sure how this was missed, but it landed on m-c a few days ago:
https://hg.mozilla.org/mozilla-central/rev/94dcc39391bc

Comment 9

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d3123e80b8da

Comment 10

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 28 Beta 8 
Device: Samsung Galaxy Tab
OS: Android 4.0.4

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 29.0a2 (2014-03-05) 
Device: Alcatel One Touch 
OS: Android 4.1.2