949786 - Modify the Email app to use the new downsample-and-decode API for image attachments

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[David Flanagan [:djf]]

When bug 854795 is fixed, we'll have a better way to reduce the size of large images, and the email app should be modified to use it when dealing with images attachments.  This will allow thumbnail images to be created without decoding the fullsize image and should save a lot of memory and prevent background apps from being killed.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Can you clarify this?  Are you proposing that if we download an attachment of type image/* that we would immediately run a transformation step against the Blob as part of the download process?  As in the rationale would be "if we download a 5 megapixel image, let's save some disk-space and turn it into a 2 megapixel image."

More specifically, the e-mail app itself currently never displays downloaded images, we only ever hand them off to the Gallery app/other apps as a File.  We do not compute thumbnails either, although I expect that's a feature we'll someday grow.  So if this isn't also about saving disk-space, I'm not sure there's anything for the e-mail app to do (until we start generating thumbnails.)

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Just realized there could also be the potential enhancement to downsample images when attaching/sending them, but I think that's something we'd depend on the gallery app to do as well, maybe?

Comment 3

[David Flanagan [:djf]]

I filed this bug assuming that the email app displayed thumbnails for image attachments.

Since you don't do it, I'll close the bug as invalid.  If you ever decide to in the future, and 854795 has landed, then you'll be able to just use the image attachment directly, but decode it at a tiny size.