949816 - Move override-EGLSurface feature out of GLContext

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: patch

Comment 1

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8346959 [details] [diff] [review]
patch

Review of attachment 8346959 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/SharedSurfaceANGLE.cpp
@@ +12,5 @@
>  namespace mozilla {
>  namespace gl {
>  
> +class GLContextEGL;
> +void SetEGLSurfaceOverride(GLContextEGL* context, EGLSurface surf);

Can we not just forward-declare void GLContextEGL::SetFOO(surf)?

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Forward-declaring a class member is not AFAIK possible?

Anyway, this will be taken care of by bug 950903, which I'm taking.

http://hg.mozilla.org/integration/mozilla-inbound/rev/f509d3187113

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f509d3187113