Closed
Bug 950049
Opened 11 years ago
Closed 11 years ago
[WebVTT] Rename VTTCue::TextTrackCueAlign to "AlignSetting" as per spec
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: reyre, Assigned: reyre)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.00 KB,
patch
|
rillian
:
review+
|
Details | Diff | Splinter Review |
This has been added to the spec and its name has changed.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8347245 -
Flags: review?(giles)
Comment 2•11 years ago
|
||
Comment on attachment 8347245 [details] [diff] [review] Bug 950049 - Rename VTTCue::TextTrackCueAlign to AlignSetting r=rillian Review of attachment 8347245 [details] [diff] [review]: ----------------------------------------------------------------- Looks like the default needs updating as well? ::: content/media/TextTrackCue.cpp @@ +40,4 @@ > mPauseOnExit = false; > mSnapToLines = true; > mLine = WEBVTT_AUTO; > + mAlign = AlignSetting::Middle; "A text track cue has a default text track cue line alignment of start." http://dev.w3.org/html5/webvtt/#dfn-text-track-cue-line-alignment Also in the parsing section, "Let cue's text track cue line alignment be start alignment." WebVTT parser algorithm step 22.7.
Attachment #8347245 -
Flags: review?(giles) → review-
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Ralph Giles (:rillian) from comment #2) > "A text track cue has a default text track cue line alignment of start." > http://dev.w3.org/html5/webvtt/#dfn-text-track-cue-line-alignment That's for the text track cue line alignment. This is for the text track cue text alignment: http://dev.w3.org/html5/webvtt/#dfn-text-track-cue-text-alignment. They've added some more alignment values recently: positionAlign and lineAlign. http://dev.w3.org/html5/webvtt/#vttcue-interface
Assignee | ||
Updated•11 years ago
|
Attachment #8347245 -
Flags: review?(giles)
Assignee | ||
Updated•11 years ago
|
Attachment #8347245 -
Flags: review?(giles)
Assignee | ||
Updated•11 years ago
|
Attachment #8347245 -
Flags: review- → review?(giles)
Comment 4•11 years ago
|
||
Comment on attachment 8347245 [details] [diff] [review] Bug 950049 - Rename VTTCue::TextTrackCueAlign to AlignSetting r=rillian Review of attachment 8347245 [details] [diff] [review]: ----------------------------------------------------------------- I stand corrected. That's not confusing at all!
Attachment #8347245 -
Flags: review?(giles) → review+
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Ralph Giles (:rillian) from comment #4) > Comment on attachment 8347245 [details] [diff] [review] > I stand corrected. That's not confusing at all! Yeah, it hurts my brain a lot of the time. Thanks for review! Try push: https://tbpl.mozilla.org/?tree=Try&rev=85ce8f2ee0a3
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/40bb8646e3f8
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/40bb8646e3f8
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•