950201 - Add search suggestions to Bing search plugin

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mike Connor [:mconnor]]

Split off from bug 903084.

Waiting on formal clarification from Bing about the correct URL to use, as well as a new API code (different from the form code) to be used for mobile.  Once we have that, I'll fix it here.

Comment 1

[Mike Connor [:mconnor]]

Attachment: bingMobileSuggestions

This _should_ be correct, but should be verified (I don't have a Fennec build env)

Comment 2

[:Margaret Leibovic]

Comment on attachment 8349738 [details] [diff] [review]
bingMobileSuggestions

Review of attachment 8349738 [details] [diff] [review]:
-----------------------------------------------------------------

I verified this makes bing suggestions appear in the UI. r+ assuming this is the correct url/parameters.

Comment 3

[Mike Connor [:mconnor]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/23eade41cfcc

Happy to take on uplifts if product people think it's worth it

Comment 4

[Karen Rudnitski [:kar]]

Mike - the thread with Bing is using language I'm not very familiar with. Is Margaret's patch in line with their expectations and are you confident it's within agreement between us and Bing (in terms of expectation, use of our currently-used FORM code, etc etc)?

Thanks!

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/23eade41cfcc

Comment 6

[Aaron Train [:aaronmt]]

testing-note (12/20): Only the default provider is currently used in fennec; not sure which is the penultimate bug to handle multiple providers

Comment 7

[Karen Rudnitski [:kar]]

Correct - and to be clear, search suggestions should only appear for the default provider if suggestions are available. So if the user has made Bing their default provider, Bing's search suggestions should appear (and not Google's, since they would not be in the default position).

Comment 8

[Kevin Brosnan [Ex-Mozilla]]

Might be worth a relnote.

Comment 9

[Mike Connor [:mconnor]]

Karen, it's actually my patch, based on Bing's confirmation that it's the correct bits to use.  We may need to change the API code, but this is functionally correct.  I'll continue to follow up and make changes where needed, but this will address the immediately urgent issue.

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Mike Connor [:mconnor] from comment #9)
> Karen, it's actually my patch, based on Bing's confirmation that it's the
> correct bits to use.  We may need to change the API code, but this is
> functionally correct.  I'll continue to follow up and make changes where
> needed, but this will address the immediately urgent issue.

I think Karen was responding to Aaron. To paraphrase, comment 6 is describing it working as intended.

Comment 11

[Ioana Chiorean]

Nightly 29.0a1 (2013-12-26)
Galaxy Tab (Android 4.0.3 )

"Would you like to turn on Bing search suggestions " is present. Choosing yes will display the suggestions. 
Settings this to VERIFIED FIXED.

Comment 12

[Ioana Chiorean]

Test cases covering this:
https://moztrap.mozilla.org/manage/case/2739/
https://moztrap.mozilla.org/manage/case/2740/
I've modify them to include bing too starting Mobile Firefox 29 (both phone and tablet).

Comment 13

[Erin Lancaster [:elan]]

It would be good to modify the relnote so that it states:  "Search suggestions are now available with the Bing search plugin when it is set as the default search engine"

Comment 14

[Erin Lancaster [:elan]]

Ok, try this: "Bing search suggestions available when set to default"

Comment 15

[alainez]

We settled on using this line and it has posted to the release notes: 
Search suggestions available via Bing search plugin when set as default search engine