950739 - In the App Manager, adding a break point scroll the page up

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Comment 1

[Paul Rouget [:paul]]

This only happens when the toolbox is *inside* the app manager (in a custom host).

Comment 2

[Paul Rouget [:paul]]

Attachment: v1

We called scrollIntoView to make sure the toolbox button was visible in the app manager. But scrollIntoView also scrolls the inner documents, like the toolbox, which messes with everything.

scrollIntoView in the app manager tabs was handy, but it's really not that useful.

And this bug blocks many people (gaia dev using the debugger).

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 8348211 [details] [diff] [review]
v1

Review of attachment 8348211 [details] [diff] [review]:
-----------------------------------------------------------------

alrighty then.

Comment 4

[Paul Rouget [:paul]]

I just want to add that hunting this bug was epic and hard. I failed to figure out what was wrong, but optimizer, blindly, figured out the whole story. I was impressed.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/1627332b2e7f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1627332b2e7f

Comment 8

[Girish Sharma [:Optimizer]]

(In reply to Paul Rouget [:paul] from comment #4)
> I just want to add that hunting this bug was epic and hard. I failed to
> figure out what was wrong, but optimizer, blindly, figured out the whole
> story. I was impressed.

I am putting this on my card : "Paul is impressed" :)