950973 - [js-marionette-client] Scope states are not isolated

Status: RESOLVED INCOMPLETE

(Testing Graveyard :: JSMarionette, defect)

Description

[Mike Pennisi [:jugglinmike]]

When new "scopes" are created via `Client#scope`, their `_scope` property is copied from the "parent" client, but their `_state` property is kept as a reference. Scoped clients should define an isolated `_state`, copied from the parent at creation time.

Comment 1

[Mike Pennisi [:jugglinmike]]

Attachment: Pull request on GitHub.com

Hey Gareth! I came across this bug while implementing your suggestion for my patch for bug 950749.

Comment 2

[Mike Pennisi [:jugglinmike]]

Gareth,

These intermittent failures are due to an unguarded references to the mobile-only `mozBluetooth` API. After some digging, I've found that the tests will also intermittently fail on a different error originating from the System application. I've opened bug 951886 and bug 951888 to track the resolution of those problems.

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8348423 [details] [review]
Pull request on GitHub.com

Thanks Mike! Sorry again for the review delay.

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/marionette-js-client/commit/e2e594aa7ef5a95e1c5ff1f762ad253650d276eb

Comment 5

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/marionette-js-client/commit/80561bcedc092ce9f76cfd7d3027433770b29175 this broke things (see https://bugzilla.mozilla.org/show_bug.cgi?id=985112)

Comment 6

[Firefox Bug Husbandry Bot]

Bulk closed as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1422750