95099 - TestGtkEmbed ... Incomplete securtiy dialogue prevents form submit

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Tracy Walker [:tracy]]

seen on TestGtkEmbed build 2001-08-13-06-trunk

-go to www.quicken.com
-enter a stock ticker the the form field
-click "go" 

the expected security dialogue pops up, but it is text only. The "cancel" and 
"okay" buttons are missing.  It is not possible to continue with the form 
submit.

Comment 1

[Adam Lock]

Could be a chrome packaging issue. I'm pulling a fresh trunk to see if I can pin
this one down.

Comment 2

[Adam Lock]

Embedding build works for me using a fresh pull...

When I enter a ticker symbol and click "Go" I am shown the "Any information you
submit is unencrypted...." dialog complete with checkbox and OK & Cancel buttons.

Comment 3

[Tracy Walker [:tracy]]

then this IS a pacakaging issue?

Comment 4

[Chris McAfee]

does this happen on other platforms, or just linux?

Comment 5

[Adam Lock]

By packaging I was guessing that maybe some chrome wasn't going into embed.jar
causing the dialog to be displayed incorrectly. For example, the locale file
containing the OK & Cancel strings.

Since it works on my build I'm unsure what it could be. It is possible that the
process that tars it all up into the nightly directory is broken or that
whatever caused the breakage has already been fixed.

I have checked the code in PSM that poses the confirmation check box, the gtk
widget and the TestGtkEmbed app and none of them seem to have changed recently.

Comment 6

[Adam Lock]

Also note that I would have tried the nightly but ftp.mozilla.org appears to be
empty at the moment.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yeah, I see this on the build in dist/Embed (after a gmake in embedding/config)
but not on the build in dist/bin.

Comment 8

[Navin Gupta]

Any ETA on this one ?

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Possibly relevant:

WARNING: CSSLoaderImpl::LoadAgentSheet: Load of URL
'chrome://global/skin/scrollbars.css' failed.  Error code: 16389, file
/builds/seamonkey/mozilla/content/html/style/src/nsCSSLoader.cpp, line 1561
Disabling Quirk StyleSheet
WARNING: CSSLoaderImpl::DidLoadStyle: Load of URL
'chrome://global/skin/global.css' failed.  Error code: 16389, file
/builds/seamonkey/mozilla/content/html/style/src/nsCSSLoader.cpp, line 935
Error reading file
jar:resource:///chrome/embed.jar!/content/global/bindings/text.xml
Error reading file
jar:resource:///chrome/embed.jar!/content/global/bindings/textbox.xml
Error reading file
jar:resource:///chrome/embed.jar!/content/global/bindings/checkbox.xml
Error reading file
jar:resource:///chrome/embed.jar!/content/global/bindings/button.xml
###!!! ASSERTION: Unable to locate an XBL binding.: 'protoBinding', file
/builds/seamonkey/mozilla/content/xbl/src/nsXBLService.cpp, line 997
###!!! Break: at file
/builds/seamonkey/mozilla/content/xbl/src/nsXBLService.cpp, line 997

Comment 10

[Adam Lock]

It works for me for mozilla/dist/Embed. 

It is possible that applying patch 45657 from bug 90707 may fix this issue but I
can't verify because it already works for me. Does anyone else want to try?

Comment 11

[Navin Gupta]

ok, i have opened the tree. looks like we have a fix in hand for this one. 

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yes, it works for me (except that there's no text on the buttons).  I had
already come up with half the patch, and your patch pointed out the spelling
mistake that explained what I needed for the other half.  r=dbaron

Comment 13

[Adam Lock]

Fix for bug 90707 is checked in. I believe it fixes the problem but I will leave
the bug open until it can be independently confirmed.

Comment 14

[Adam Lock]

Changing to critical pending confirmation

Comment 15

[Tracy Walker [:tracy]]

seeing fixed on build 2001-08-14-17-trunk

the dialogue works fine now (although as David Baron pointed out there isn't any 
text on the buttons)

I am going to leave it open until the button text is fixed.

Comment 16

[Tracy Walker [:tracy]]

marking fixed as seen on TestGtkEmbed on 2001-08-22-06-trunk;

the buttons now have the proper text.

Comment 17

[Tracy Walker [:tracy]]

verified on TestGtkEmebed 2001-09-25-06-trunk