951699 - "Delete Groups" warning for groups on products is misleading

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Gervase Markham [:gerv]]

If you go to delete a group, it warns you about possible problems you may have. It lists all products for which that group is enabled, and sometimes it says:

"WARNING: This product is currently hidden. Deleting this group will make this product publicly visible."

However, this message does not match the conditions which display it.

The code in delete.html.tmpl goes like this:

        [% SET hidden = 0 %]
        [% IF data.controls.othercontrol == constants.CONTROLMAPMANDATORY
              AND data.controls.membercontrol == constants.CONTROLMAPMANDATORY
              AND data.controls.entry 
        %]
          [% SET hidden = 1 %]
        [% END %]

        ...

          [% IF hidden %]
            <strong>WARNING: This product is currently hidden.
            Deleting this group will make this product publicly visible.
            </strong>
          [% END %]

 So the message is displayed if the group to be deleted is MANDATORY/MANDATORY/Entry. Deleting it will certainly make the product _more_ visible (if you are using AND groups), but it will not necessarily make it public - that depends on what other groups are set on the product.

We should either update the logic to be more complex, or change the error message, or simply remove it. And we need to cope with the OR groups case.

Gerv

Comment 1

[Frédéric Buclin]

(In reply to Gervase Markham [:gerv] from comment #0)

> "WARNING: This product is currently hidden. Deleting this group will make
> this product publicly visible."

To not make the code too complex, we should simply reword it to something like s/will/could/ and appending "if no other group applies" or something similar.

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

As suggested by LpSolit.

Gerv

Comment 3

[Frédéric Buclin]

Comment on attachment 8371533 [details] [diff] [review]
Patch v.1

r=LpSolit

Comment 4

[Gervase Markham [:gerv]]

Committing  to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                                                                                                                                                          
modified template/en/default/admin/groups/delete.html.tmpl
Committed revision 8909.     

Gerv

Comment 5

[Frédéric Buclin]

Please also commit to the 4.4 branch and close the bug.

Comment 6

[Gervase Markham [:gerv]]

Committing  to: bzr+ssh://[e-mail]@bzr.mozilla.org/bugzilla/4.4/                   
modified template/en/default/admin/groups/delete.html.tmpl
Committed revision 8655.

Gerv