951932 - [Ringtones] remove the ability to pick a ringtone from the Music app in 1.3

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[David Flanagan [:djf]]

At the beginning of the 1.3 cycle I added the ability to select a ringtone from the Music app via a pick activity.  In 1.3, when you use the settings app to change your ringtone, you always have to choose between "System Ringtones" and "Music".

This turns out to be a misfeature. We already have the ability to share a song as a ringtone, and the pick from music feature will be removed in 1.4.

We should also remove it from 1.3 so it is not an orphan feature that exists (and forces and extra click) in just one release.

This will be a one-line patch, but I'm going to nominate it as a blocker because we really want to get ringtones right in 1.4 and don't want a backward compatibility headache for 1.3.

Comment 1

[David Flanagan [:djf]]

Nominating for 1.3. 

Needinfo for Hema so it is on her radar and so she can talk about this during triage.

And cc Jacqueline since she is the ringtone UX lead.

Comment 2

[Hema Koka [:hema]]

This did not show up in my triage query, because it was in the Settings component. However, based on the discussions that we had today for Ringtone in 1.4, it makes sense to remove it from 1.3. I don't want to mark this a 1.3+ because it is not a blocker per se. We can approve the patch for 1.3 since it is a low risk one line change provided Fabrice also agrees (he is the 1.3 sheriff)

NI'd Sri to ensure we dont have objections from product side to remove it.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: please ask for approval for the patch.

Comment 4

[[:fabrice] Fabrice Desré]

I don't have any objection sto take that on 1.3

Comment 5

[David Flanagan [:djf]]

Attachment: one-line patch

Comment 6

[David Flanagan [:djf]]

This patch Fabrice's approval to land in 1.3.

I have offline UX review from Jacqueline.

Comment 7

[Diego Marcos [:dmarcos]]

The patch looks good to me.

Comment 8

[David Flanagan [:djf]]

Landed on master: https://github.com/mozilla-b2g/gaia/commit/8cbb66618c118aba48fd6f49b830f5f76a77e5fb

Comment 9

[David Flanagan [:djf]]

Uplifted to v1.3 with approval above from Fabrice: https://github.com/mozilla-b2g/gaia/commit/5218575ec22e6b69c4bc75ee297ff1fb07fd2cb2