Closed
Bug 952190
Opened 11 years ago
Closed 10 years ago
Pretty output for native objects from chrome windows
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 30
People
(Reporter: msucan, Assigned: msucan)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
2.77 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
We should have pretty output for native objects from chrome windows, like we have for objects from content tabs. (follow up from bug 843004 comment 49)
Updated•10 years ago
|
Priority: -- → P3
Assignee | ||
Comment 2•10 years ago
|
||
Gijs, to fix this bug, update DevToolsUtils.js: this.isSafeJSObject = function isSafeJSObject(aObj) { if (Cu.getGlobalForObject(aObj) == Cu.getGlobalForObject(isSafeJSObject)) { return true; // aObj is not a cross-compartment wrapper. } if (Cu.getObjectPrincipal(aObj) == Cu.getObjectPrincipal(isSafeJSObject) { return true; // allow chrome objects } return Cu.isXrayWrapper(aObj); }; ... then write a test. Please use Task.spawn for the test.
Comment 3•10 years ago
|
||
And on came a deluge of other stuff that was almost-but-not-quite-literally on fire. Needinfo'ing so I don't forget.
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 4•10 years ago
|
||
This is a quick fix that's useful for addon authors and for Firefox devs. My previous comment was not entirely accurate. It seems the getObjectPrincipal() method was moved to the script security manager.
Assignee | ||
Comment 5•10 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=b94df5d9ad19
Comment 6•10 years ago
|
||
Comment on attachment 8377727 [details] [diff] [review] bug952190-1.diff Review of attachment 8377727 [details] [diff] [review]: ----------------------------------------------------------------- I see some breakage in tbpl, so clearing review for now.
Attachment #8377727 -
Flags: review?(past)
Assignee | ||
Comment 7•10 years ago
|
||
Fixed the variables view test. Green try push: https://tbpl.mozilla.org/?tree=Try&rev=cc4f30d3506b
Attachment #8377727 -
Attachment is obsolete: true
Attachment #8378395 -
Flags: review?(past)
Comment 8•10 years ago
|
||
Comment on attachment 8378395 [details] [diff] [review] bug952190-2.diff Review of attachment 8378395 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8378395 -
Flags: review?(past) → review+
Updated•10 years ago
|
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 9•10 years ago
|
||
Thanks! Landed: https://hg.mozilla.org/integration/fx-team/rev/47fddf9651fd
Whiteboard: [fixed-in-fx-team]
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/47fddf9651fd
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
Updated•10 years ago
|
Whiteboard: [qa-]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•