952205 - topcrasher_ranks_bybug should only include active versions

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Robert Helmer [:rhelmer]]

Right now topcrasher_ranks_bybug iterates over every product+version that SignatureSummary returns, inactive versions should be excluded instead.

Comment 1

[Robert Helmer [:rhelmer]]

Attachment: filter out inactive versions

Not a complete solution but helps performance quite a bit (takes things from "so slow they are timing out" to merely "slow" for the most pathological case I know about, which is searching for 711568)

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #1)
> Created attachment 8350211 [details] [review]
> filter out inactive versions
> 
> Not a complete solution but helps performance quite a bit (takes things from
> "so slow they are timing out" to merely "slow" for the most pathological
> case I know about, which is searching for 711568)

BTW I meant "not a complete solution" regarding performance, the PR is intended to be a complete solution to filtering non-active versions :)

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/3834ec7b5b041249cacc7f15fd7194fcb1e04d00
bug 952205 - exclude inactive versions from topcrasher_ranks_bybug report

https://github.com/mozilla/socorro/commit/111d5f5b1a0f4711b57c6d423247df3f2c237531
Merge pull request #1760 from rhelmer/bug952205-exclude-inactive-versions

bug 952205 - exclude inactive versions from topcrasher_ranks_bybug repor...

Comment 4

[Matt Brandt [:mbrandt]]

Bumping to verified as [qa-].