952623 - Error "use of undeclared identifier" if building with macos-target=10.9

Status: RESOLVED DUPLICATE of bug 1123356

(Toolkit :: Crash Reporting, defect)

Description

[Nomis101]

As noted in https://bugzilla.mozilla.org/show_bug.cgi?id=909914#c6 if building on Mac with macos-target=10.9 you see two errors.


/Volumes/Developer/mozilla-central/toolkit/crashreporter/google-breakpad/src/client/mac/crash_generation/crash_generation_server.cc:67:30: error: 
      use of undeclared identifier 'pthread_create'
  int thread_create_result = pthread_create(&server_thread_, NULL,
                             ^
/Volumes/Developer/mozilla-central/toolkit/crashreporter/google-breakpad/src/client/mac/crash_generation/crash_generation_server.cc:83:30: error: 
      use of undeclared identifier 'pthread_join'; did you mean 'pthread_kill'?
    int thread_join_result = pthread_join(server_thread_, NULL);
                             ^~~~~~~~~~~~
                             pthread_kill
/Developer/SDKs/MacOSX10.9.sdk/usr/include/signal.h:80:5: note: 'pthread_kill'
      declared here
int     pthread_kill(pthread_t, int);

Comment 1

[Nomis101]

Attachment: Fix

This will fix the two errors.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8350758 [details] [diff] [review]
Fix

Review of attachment 8350758 [details] [diff] [review]:
-----------------------------------------------------------------

I'll land this upstream for you.

Comment 3

[(not currently active) Ted Mielczarek]

http://code.google.com/p/google-breakpad/source/detail?r=1268

Comment 4

[Nomis101]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> Comment on attachment 8350758 [details] [diff] [review]
> Fix
> 
> Review of attachment 8350758 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'll land this upstream for you.
Thanks!

Comment 5

[(no longer active)]

Sorry, I ended up rewriting this.  :-)