952805 - [Usage][l12y] wifi-usage and mobile-usage are reused in different contexts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Théo Chevalier]

The strings wifi-usage and mobile-usage are used in different contexts. (Chart view and settings).
Localizers may want to adjust the size in each view, there is more room in settings and it looks weird to have shortened strings there.

Comment 1

[Théo Chevalier]

Attachment: Link to Github PR

I'm not very happy with the comment. Francesco, what do you think?

Comment 2

[Francesco Lodolo [:flod]]

What about just:

> # LOCALIZATION NOTE (wifi-usage-settings, mobile-usage-settings): these strings 
> # are displayed in the Settings section

I would also add a similar comment for the existing strings (wifi-usage, mobile-usage), saying that they're displayed in the main window. No need to explain we're talking about Usage, since strings are per app.

Comment 3

[Théo Chevalier]

Comment on attachment 8351028 [details] [review]
Link to Github PR

Thanks Francesco.

Salvador, could you take a look please? :)

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 8351028 [details] [review]
Link to Github PR

I like it. Go on and thank you. Can you merge or do you need me? Ping me if so.

Comment 5

[Théo Chevalier]

(In reply to Salvador de la Puente González [:salva] from comment #4)
> Comment on attachment 8351028 [details] [review]
> Link to Github PR
> 
> I like it. Go on and thank you. Can you merge or do you need me? Ping me if
> so.

Thanks!

Need you :) (I don't have rights)

Comment 6

[Salvador de la Puente González [:salva]]

Master: 84d34f650885f2e37c1b445ff1109a0c422b0324