952844 - Move pdf.js from /browser to a toplevel directory

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect, P4)

Description

[Matt Brubeck (:mbrubeck)]

Currently pdf.js and Shumway are checked in to /browser/extensions for desktop Firefox.  Android and Metro Firefox do hacky things to build separate copies from that directory.  This is especially bad for installer size on Windows, where we ship two copies of each extension (one in browser and one in metro).

We should move these files to a location where we can more easily share them between apps, and install them just once on Windows.  Would /toolkit/extensions work?  Any other suggestions?

Comment 1

[Matt Brubeck (:mbrubeck)]

We should make sure this can work for Firefox OS in the future, too.

Comment 2

[Philip Chee]

(In reply to Matt Brubeck (:mbrubeck) from comment #0)
> We should move these files to a location where we can more easily share them
> between apps, and install them just once on Windows.  Would
> /toolkit/extensions work?  Any other suggestions?

/extensions/ already exists.
/toolkit/components/ too.
I'd dis-recommend the badly named /toolkit/mozapps/
And whose bright idea was it to have /toolkit/mozapps/extensions/ ?

Comment 3

[Benjamin Smedberg]

This should be a new toplevel directory. Flat is better.

Comment 4

[Yury Delendik (:yury)]

Also keep in mind that portions on the projects might differ between platforms, e.g. pdf.js for ffos, android and desktop will have different viewers however core part will stay the same.

Comment 5

[Gregory Szorc [:gps]]

Brendan has to sign off on the creation of new toplevel directories.

Bikeshed: why can't we move things under /extensions?

Comment 6

[Benjamin Smedberg]

Because flat is better (Brendan and I have discussed/agree!) and extensions has been a dumping ground for crap over the years.

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

It moved to toolkit in 80 in bug 1618465.