952928 - two Cocoa objects (one Dictionary, one Array) leaked during startup

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Jonathan Kew [:jfkthame]]

Attachment: getsystemversion-autorelease

Observed during launch, since the refactoring of OS X version checks in bug 676907:

objc[12683]: Object 0x1004bc7c0 of class __NSCFDictionary autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug
objc[12683]: Object 0x1004ca7f0 of class __NSArrayM autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug

Patch attached.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Ensure an autorelease pool is in place in InitializeVersionNumbers() before calling Cocoa APIs.

Oops, that needs an extra #include or else it'll break in non-unified builds. Sorry for the churn.

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 8351177 [details] [diff] [review]
Ensure an autorelease pool is in place in InitializeVersionNumbers() before calling Cocoa APIs.

Thanks!

Comment 3

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f5ac5ff7d43

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0f5ac5ff7d43