953548 - DNS SRV queries broken (timeout add and threading issues)

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Florian Quèze [:florian]]

*** Original post on bio 97 at 2008-08-12 14:26:00 UTC ***

DNS SRV queries are broken on Windows because libpurple uses (in Windows-only portions of the code) purple_timeout_add as a way to get a callback on the main thread.

This is not supported by our current implementation of purpleTimer.

Comment 1

[Florian Quèze [:florian]]

Attachment: fix

*** Original post on bio 97 as attmnt 58 at 2008-08-14 02:53:00 UTC ***

On Windows the timeout_add ui op of libpurple is overloaded.
It is used both for real timeouts and as a thread synchronization method.

In the case of the thread synchronization (which I just implemented with this patch), I assume that:
 - The return value will not be used (the timeout won't be cancelable)
 - The interval is always 0.

These assumptions are corrects for the 4 uses cases in the current libpurple code base, and a developer in #pidgin told me that it is not likely to change before at least libpurple 3.0.

The current 4 use cases are: dnsquery.c, dnssrv.c bonjour.c and network.c
For Instantbird we can ignore the dnsquery.c case because we don't use libpurple's builtin DNS resolution but implemented the DNS ui ops.

Comment 2

[Florian Quèze [:florian]]

*** Original post on bio 97 at 2008-08-14 03:07:01 UTC ***

Sending        purple/purplexpcom/src/purpleTimer.cpp
Sending        purple/purplexpcom/src/purpleTimer.h
Transmitting file data ..
Committed revision 278.

Fixed.