953993 - (CVE-2014-1484) Fennec leaks profile path to logcat

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

Kinda makes Bug 944373 unnecessary!

                Log.d(LOGTAG, "Found profile dir: " + mProfileDir.getAbsolutePath());

12-29 21:40:07.011 D/GeckoProfile( 5655): Found profile dir: /data/data/org.mozilla.fennec_rnewman/files/mozilla/$hash.default

Comment 1

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

Comment 2

[Roee Hay]

Please note that I also used this vulnerability in the exploit of bug #944374. Also note that reading the logs of other apps is impossible in Jelly Bean and above.

Comment 3

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/d531cccd308c

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 8352340 [details] [diff] [review]
Proposed patch. v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  Long time.

User impact if declined: 
  Profile paths leak to system log, which on less-modern Android versions gives other applications a head-start on fishing files (e.g., password databases) out of the user's profile directory.

Testing completed (on m-c, etc.): 
  Tested locally. Just landed.

Risk to taking this patch (and alternatives if risky): 
  ~0. Logging-only changes.

String or IDL/UUID changes made by this patch:
  None.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d531cccd308c

Comment 6

[Richard Newman [:rnewman]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fe438b8e6dc5
https://hg.mozilla.org/releases/mozilla-beta/rev/4efbfe0c7320