954762 - Tab complete: Be smart about multiple completions

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[aleth [:aleth]]

*** Original post on bio 1330 at 2012-03-09 00:44:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1330 as attmnt 1235 at 2012-03-09 00:44:00 UTC ***

When completing a nick preceded by ": " (i.e. usually a previous chat nick completion), check if what is before the colon is a nick. If so, replace the ":" with a comma. Useful when addressing more than one person.

Comment 2

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1330 as attmnt 1245 at 2012-03-10 18:49:00 UTC ***

Nit and bug fix (do not show added comma in list of completions).

Comment 3

[aleth [:aleth]]

Comment on attachment 8352988 [details] [diff] [review]
Patch

*** Original change on bio 1330 attmnt 1235 at 2012-03-10 18:49:11 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 4

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1330 as attmnt 1246 at 2012-03-10 18:59:00 UTC ***

Contrary to what I thought, single-letter nicks are actually allowed! (Not that you need tab complete for those really...)

Comment 5

[aleth [:aleth]]

Comment on attachment 8352998 [details] [diff] [review]
Patch

*** Original change on bio 1330 attmnt 1245 at 2012-03-10 18:59:35 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 6

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1330 as attmnt 1291 at 2012-04-04 17:39:00 UTC ***

- Check the entire sequence of preceding words are nicks.
- Continue to work seamlessly after a partial completion has occurred.

Comment 7

[aleth [:aleth]]

Comment on attachment 8352999 [details] [diff] [review]
Patch

*** Original change on bio 1330 attmnt 1246 at 2012-04-04 17:39:04 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 8

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1330 as attmnt 1292 at 2012-04-04 17:51:00 UTC ***

Streamlined: Who cares if we overwrite a comma with a comma?

Comment 9

[aleth [:aleth]]

Comment on attachment 8353044 [details] [diff] [review]
Patch

*** Original change on bio 1330 attmnt 1291 at 2012-04-04 17:51:32 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 10

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1330 as attmnt 1293 at 2012-04-04 17:54:00 UTC ***

Teeny tiny efficiency improvement ;)

Comment 11

[aleth [:aleth]]

Comment on attachment 8353045 [details] [diff] [review]
Patch

*** Original change on bio 1330 attmnt 1292 at 2012-04-04 17:54:43 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 12

[Florian Quèze [:florian]]

Comment on attachment 8353046 [details] [diff] [review]
Patch

*** Original change on bio 1330 attmnt 1293 at 2012-04-04 22:22:49 UTC ***

Thanks for this nice UX improvement! :)

Comment 13

[Patrick Cloke [:clokep]]

*** Original post on bio 1330 at 2012-04-04 23:39:50 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/3f1604de4278

Can't wait to try this out!