954853 - No/incorrect error message when joining a channel fails

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[aleth [:aleth]]

*** Original post on bio 1418 at 2012-05-02 16:28:00 UTC ***

Both via "Join chat" and /join, the only feedback currently is the server tab error message
"There is no channel: aleth."
(note I did _not_ attempt to join a channel named aleth - the error message picks up the wrong parameter?)

For "Join chat" one would probably expect feedback in the dialog box (and the chance to try again), for /join in the conversation.

Comment 1

[Patrick Cloke [:clokep]]

Attachment: Patch

*** Original post on bio 1418 as attmnt 1434 at 2012-05-04 00:37:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 2

[aleth [:aleth]]

Comment on attachment 8353186 [details] [diff] [review]
Patch

*** Original change on bio 1418 attmnt 1434 at 2012-05-04 09:18:01 UTC ***

Works very well. It would be nice if one could do without opening the tab for the nonexisting channel, but that seems almost impossible.

Thanks for fixing this!

Comment 3

[Florian Quèze [:florian]]

*** Original post on bio 1418 at 2012-05-04 09:28:21 UTC ***

Comment on attachment 8353186 [details] [diff] [review] (bio-attmnt 1434)
Patch

>diff --git a/chat/protocols/irc/ircBase.jsm b/chat/protocols/irc/ircBase.jsm

>-      return serverErrorMessage(this, aMessage,
>-                                _("error.noChannel", aMessage.params[0]));
>+      conversationErrorMessage(this, aMessage, "error.noChannel");
>+      return true;

Why not just:
      return conversationErrorMessage(this, aMessage, "error.noChannel");
?

Comment 4

[Patrick Cloke [:clokep]]

Attachment: Patch v2

*** Original post on bio 1418 as attmnt 1436 at 2012-05-04 10:29:00 UTC ***

Florian: you're right, carrying the review forward.

Comment 5

[Patrick Cloke [:clokep]]

Comment on attachment 8353186 [details] [diff] [review]
Patch

*** Original change on bio 1418 attmnt 1434 at 2012-05-04 10:29:54 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 6

[Florian Quèze [:florian]]

*** Original post on bio 1418 at 2012-05-04 23:33:37 UTC ***

https://hg.instantbird.org/instantbird/rev/194399651469