954971 - Error when attempting to read plaintext logs

Status: RESOLVED FIXED

(Instantbird Graveyard :: Other, defect)

Description

[Patrick Cloke [:clokep]]

*** Original post on bio 1539 at 2012-06-22 21:39:00 UTC ***

When trying to read a plaintext log an error is thrown and the log is not loaded:
Error: browser.documentCharsetInfo is undefined Source File: chrome://instantbird/content/viewlog.js
Line: 91

5:36:00 PM - flo: clokep: https://developer.mozilla.org/en/XUL/Property/documentCharsetInfo "The properties of the nsIDocumentCharsetInfo object were merged into the docshell in Gecko 12.0 (Firefox 12.0 / Thunderbird 12.0) ."
5:36:49 PM - flo: clokep: I think the fix is replacing browser.documentCharsetInfo.forcedCharset with browser.docShell.forcedCharset
5:37:39 PM - flo: I think in the same patch you want to get rid of http://lxr.instantbird.org/instantbird/source/instantbird/content/tabbrowser.xml#1196

Comment 1

[Patrick Cloke [:clokep]]

*** Original post on bio 1539 at 2012-06-22 21:41:22 UTC ***

clokep: the changeset is http://hg.mozilla.org/mozilla-central/rev/57f0b07c2dc5

Comment 2

[Patrick Cloke [:clokep]]

Attachment: Patch

*** Original post on bio 1539 as attmnt 1695 at 2012-06-26 00:01:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8353452 [details] [diff] [review]
Patch

*** Original change on bio 1539 attmnt 1695 at 2012-06-26 08:52:01 UTC ***

Thanks!

Comment 4

[Patrick Cloke [:clokep]]

*** Original post on bio 1539 at 2012-06-26 23:47:22 UTC ***

Fixed in http://hg.instantbird.org/instantbird/rev/9b19d9ef0263