955574 - Enable JS Yahoo By Default

Status: RESOLVED FIXED

(Chat Core :: Yahoo! Messenger, defect)

Description

[Quentin Headen [:qheaden]]

*** Original post on bio 2135 at 2013-08-28 01:54:00 UTC ***

JS Yahoo is currently in the main source tree, but it is turned off by default. Once the plug-in is seen as feature complete and stable enough for public use, it should be enabled by default, taking the place of the libpurple Yahoo plugin.

Comment 1

[Quentin Headen [:qheaden]]

Attachment: Patch 1

*** Original post on bio 2135 as attmnt 2807 at 2013-08-30 17:59:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 2

[aleth [:aleth]]

Comment on attachment 8354577 [details] [diff] [review]
Patch 1

*** Original change on bio 2135 attmnt 2807 at 2013-09-03 10:33:38 UTC ***

Stealing this review :)

Comment 3

[Patrick Cloke [:clokep]]

*** Original post on bio 2135 at 2013-09-03 10:36:28 UTC ***

I was purposefully leaving this open so that we wouldn't lose this bug when we want to check it in.

Removing checkin-needed whiteboard since we DON'T want to check this in until it's clear we want to enable it by default. I'm still waiting for Quentin to come put blockers on this bug saying what's necessary for this to be enabled by default.

Comment 4

[aleth [:aleth]]

Comment on attachment 8354577 [details] [diff] [review]
Patch 1

*** Original change on bio 2135 attmnt 2807 at 2013-09-03 17:03:43 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 5

[Patrick Cloke [:clokep]]

Comment on attachment 8354577 [details] [diff] [review]
Patch 1

*** Original change on bio 2135 attmnt 2807 at 2013-09-03 18:03:21 UTC ***

This looks fine, but let's get the blockers done before checking this in.

Comment 6

[Patrick Cloke [:clokep]]

We need to also enable this for Thunderbird:
http://mxr.mozilla.org/comm-central/source/chat/protocols/yahoo/moz.build#6 (needs to be removed)
http://mxr.mozilla.org/comm-central/source/im/installer/package-manifest.in#229 (needs to be added to mail/installer/package-manifest.in)

And tested, of course.

Comment 7

[Patrick Cloke [:clokep]]

Attachment: Enable for TB v1

I have no idea who actually needs to review this (since it's touching mail/installer), but Quentin should look over it first. I tested this briefly, I could connect my account and receive messages.

Comment 8

[Quentin Headen [:qheaden]]

Comment on attachment 8478748 [details] [diff] [review]
Enable for TB v1

So sorry for the late review. I finally found time to build Thunderbird, and it finally built for me. :-)

JS-Yahoo seems to work well within it.

Comment 9

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/40e9e5697656
https://hg.mozilla.org/comm-central/rev/82716d4fb208

Comment 11

[Wayne Mery (:wsmwk)]

Does this add functionality or UI that should be tested by users? If so, what are the instructions to test?

Comment 12

[Patrick Cloke [:clokep]]

(In reply to Wayne Mery (:wsmwk, use Needinfo for questions) from comment #11)
> Does this add functionality or UI that should be tested by users? If so,
> what are the instructions to test?

It's an extra chat protocol. Someone could connect to Yahoo! Messenger, test that they can send/receive messages. I kind of doubt we even do this with IRC/XMPP right now though.