Closed
Bug 955672
Opened 10 years ago
Closed 10 years ago
Use defineLazyModuleGetter instead of defineLazyGetter
Categories
(Chat Core :: General, defect)
Chat Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: clokep, Assigned: clokep)
Details
Attachments
(1 file, 1 obsolete file)
2.86 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 2224 at 2013-10-16 14:05:00 UTC *** There are instances we use defineLazyGetter instead of defineLazyModuleGetter, this will simplify some code, see http://mxr.mozilla.org/mozilla-central/source/accessible/src/jsat/OutputGenerator.jsm#32 as an example.
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 2224 as attmnt 2961 at 2013-10-16 14:20:00 UTC *** This depends on the patch in bug 955606 (bio 2165).
Attachment #8354742 -
Flags: review?(florian)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8354742 [details] [diff] [review] Patch *** Original change on bio 2224 attmnt 2961 at 2013-10-16 14:22:33 UTC *** Thanks!
Attachment #8354742 -
Flags: review?(florian) → review+
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 2224 as attmnt 2963 at 2013-10-18 11:39:00 UTC *** I really bitrotted this, so I'm re-requesting review, but I think it's fine.
Attachment #8354745 -
Flags: review?(florian)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8354742 [details] [diff] [review] Patch *** Original change on bio 2224 attmnt 2961 at 2013-10-18 11:39:15 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354742 -
Attachment is obsolete: true
Comment 5•10 years ago
|
||
Comment on attachment 8354745 [details] [diff] [review] Patch unbitrotted *** Original change on bio 2224 attmnt 2963 at 2013-10-18 12:07:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354745 -
Flags: review?(florian) → review+
Assignee | ||
Comment 6•10 years ago
|
||
*** Original post on bio 2224 at 2013-10-18 22:15:16 UTC *** http://hg.instantbird.org/instantbird/rev/ff81447d30da
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•