956319 - [Homescreen] Short, high velocity swipes should move to next view

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Jan Jongboom [:janjongboom] (inactive)]

I was observing a user using my FFOS device last week; and this user was making high velocity swipes over short distance, instead of swipes over a long distance. His swipes didn't make the threshold for the next view.

I think the threshold should be dependent on the velocity of the swipe.

Comment 1

[Wilson Page [:wilsonpage]]

Attachment: video

Comment 2

[Wilson Page [:wilsonpage]]

I too have noticed this regression between 1.2 and 1.3.

I am constantly having to re-swipe because me first swipe wasn't over a long enough distance. This makes the device feel stubborn and unresponsive. I feel this is important as it's probably one of the first interactions many users will have with FXOS.

I'm feeling as though this must have been noticed by visual/ux.

Comment 3

[Wilson Page [:wilsonpage]]

Please observe attached video.

Comment 4

[Wilson Page [:wilsonpage]]

http://www.youtube.com/watch?v=Yls3M7ySnls

Comment 5

[Gregor Wagner [:gwagner]]

Lets do a sanity check from the UX team if we should fix this.

Comment 6

[Stephany Wilkes]

Flagging Casey on this, though Rob may also be able to help. We've also seen this in user testing previously.

Comment 7

[Rob MacDonald [:robmac]]

Thanks for pointing this out and I agree that it's an issue. Casey, any ideas who would define this threshold? We should consider this for Gallery and similar apps as well.

Comment 8

[Gregor Wagner [:gwagner]]

Ping? Can we get some movement here?

Comment 9

[Gregor Wagner [:gwagner]]

According to comment 2 this is a regression.

Comment 10

[Rachel Pribble [:rpribble]]

Hi, not entirely sure what was needed on this one so I performed the QAWanted tag. If anything else is needed, just let me know.

Reproduces on v1.3. Short, high velocity swipes make the homescreen stutter, do not fully swipe user's view to the next homescreen page.
Reproduces on v1.2. Short, high velocity swipes make the homescreen stutter, do not fully swipe user's view to the next homescreen page.
Unable to reproduce v1.1, functions correctly. Short, high velocity swipes fully transition the user's view to the next homescreen page.

Environmental Variables:
Device: buri v1.3 moz ril
BuildID: 20140224004003
Gaia: 5084b832f3b536f60ccdb38c14fd6162e5bfbac0
Gecko: 61875a0aa4cf
Version: 28.0
Firmware Version: v1.2-device.cfg

Environmental Variables:
Device: buri v1.2 moz
BuildID: 20140220004002
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Gecko: 2ea6a65eea23
Version: 26.0
Firmware Version: v1.2-device.cfg

Environmental Variables:
Device: buri v1.1 moz ril
BuildID: 20140218041202
Gaia: c5cb252e5d1aa45d14f3a2ea182e73e2271e4496
Gecko: d7f2811943d1
Version: 18.0
Firmware Version: v1.2-device.cfg

Comment 11

[Jason Smith [:jsmith]]

UX - Feel free to weigh in here on whether you think this is a blocker for 1.3 or not.

Comment 12

[Francis Djabri [:djabber]]

If this is a regression, then it should be a blocker for 1.3. As Wilson mentioned, this is a key interaction, one which users will perform constantly.

Comment 13

[Gregor Wagner [:gwagner]]

Dale, can you take a look here? Lets fix it for 1.4 and decide about an uplift once we know whats going on.

Comment 14

[Jason Smith [:jsmith]]

Actually, let's push this into the 1.3? bucket given comment 12

Comment 15

[Stephany Wilkes]

Thank you, Jason. This should definitely block 1.3.

Comment 16

[Casey Yee]

No idea what is going on here.   I believe Vivien should be the one to flag for this issue since he is most familiar with the home screen.

Comment 17

[Dale Harvey (:daleharvey)]

I am having a hard time noticing any specific regression between 1.2 and 1.3, its quite a naunced interaction and its hard without having 2 of the same devices with different versions to compare at the same time. But in both cases I am seeing a lot of instances of it being a bit too sticky

Will take a look, definitely want to hear from vivien, I expect this wont be a trivial fix

Comment 18

[Jason Smith [:jsmith]]

(In reply to Dale Harvey (:daleharvey) from comment #17)
> I am having a hard time noticing any specific regression between 1.2 and
> 1.3, its quite a naunced interaction and its hard without having 2 of the
> same devices with different versions to compare at the same time. But in
> both cases I am seeing a lot of instances of it being a bit too sticky
> 
> Will take a look, definitely want to hear from vivien, I expect this wont be
> a trivial fix

comment 10 indicates this reproduces on 1.2 actually, but it works fine on 1.1.

Comment 19

[Dale Harvey (:daleharvey)]

My buri is bricked and geeksphone arent building v1.1 properly (http://downloads.geeksphone.com/keon/v1-train/latest_v1-train.html) 

Will do a build and attempt to revive hamachi at the same time

Comment 20

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Dale Harvey (:daleharvey) from comment #17)
> I am having a hard time noticing any specific regression between 1.2 and
> 1.3, its quite a naunced interaction and its hard without having 2 of the
> same devices with different versions to compare at the same time. But in
> both cases I am seeing a lot of instances of it being a bit too sticky
> 
> Will take a look, definitely want to hear from vivien, I expect this wont be
> a trivial fix

Sounds a good candidate for Christian.

One thing though is that there is a big jank (due to graphics) when swipping between 2 panels. Those can results into the velocity beeing miscalculated (and this is not easy to fix).

In the best case this is just a Gaia issue. In the worst case this is some platform issue from the move from b2g_18 to b2g_26.

Please notice too that I would like to change the homescreen panning heuristic for 1.5. Instead of having multiple divs that are translated by JS following the fingers, we could move to a big horizontal div that is using APZC and css scroll snapping (bug 945584) to snap to the correct position.

There may even be some platform supports for flinging (needinfo? Miranda to have the bug number if any.). So that's basically what we should use for the homescreen and gallery at the end, as it will provide a performant and consistent panning experience for those apps.


Christian, can you try to install a 1.1 version of the homescreen on your device and see if you can reproduce the issue ? If yes, it may indicate that this is a Gecko issue from the big jump between 1.1 and 1.2. And in this case it may be overkill to target that for 1.3 and instead bet on the apzc + css snapping future homescreen.

Comment 21

[Dale Harvey (:daleharvey)]

I managed to revive hamachi, I flash a pvt build of 1.1 and it was broken, homescreen swipes started shaking and phone eventually crashed, 1.2 / 1.3 builds look broken - https://bugzilla.mozilla.org/show_bug.cgi?id=977031

Comment 22

[Cristian Rodriguez (:crdlc)]

The threshold was dependent on the velocity of the swipe :) If it is now working right now some regression for sure. I will take a look. Thx

Comment 23

[Dale Harvey (:daleharvey)]

Cristian, do you wanna steal this then? assuming my hamachi's base build is outdated as every build I flash crashes so not going to be much help debugging

Comment 24

[Cristian Rodriguez (:crdlc)]

Yep, I have the fix in a couple of minutes thought

Comment 25

[Cristian Rodriguez (:crdlc)]

It just to play with the virtual friction and the threshold that in v1-train was 25% of the screen

Comment 26

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

In v1-train we had 25% of the screen a threshold and I think that it should be changed by mistake. Also, I've recovered a code from v1-train that worked like a charm

Thanks Vivien

Comment 27

[Julien Wajsberg [:julienw]]

Ahah this recalls me of bug 887509 ;) (although I prefer your fix here, Cristian)

Comment 28

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8382241 [details]
Patch v1

Sounds safe and easy.

Comment 29

[Cristian Rodriguez (:crdlc)]

The problem is that this patch does not uplift to v1.3 cleanly because the build process has been changed in master, perhaps, if it would be 1.3+ finally, I will have to do a pr for 1.3 too

Comment 30

[Rachel Pribble [:rpribble]]

Environmental Variables:
Device: buri v1.1 moz ril 
BuildID: 20140213041204
Gaia: c5cb252e5d1aa45d14f3a2ea182e73e2271e4496
Gecko: 2e2d6605f51d
Version: 18.0
Firmware Version: v1.2-device.cfg

Environmental Variables:
Device: buri v1.2 moz ril
BuildID: 20130621031231
Gaia: e2f19420fa6a26c4287588701efaec09a750dba1
Gecko: 7ba8c86f1a56
Version: 24.0a1
Firmware Version: v1.2-device.cfg

Last working Gaia/First broken Gecko: Issue does not reproduce
Gaia: c5cb252e5d1aa45d14f3a2ea182e73e2271e4496
Gecko: 7ba8c86f1a56

First broken Gaia/Last working Gecko: Issue reproduces
Gaia: e2f19420fa6a26c4287588701efaec09a750dba1
Gecko: 2e2d6605f51d

Comment 31

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 32

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/2594455d08936b8ff1b907dd50b6426482377474

Comment 33

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8382241 [details]
Patch v1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: fast gestures don't imply changes among pages
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]:

Comment 34

[John Hammink]

I am now able to verify this is working with both long and short swipes (with velocity).

I am also able to pan one pane to the next with short, slow swipes.

Gaia      9422aca1931ba6c68784f9e80bb1b6a7fcfd92e3
Gecko     https://hg.mozilla.org/mozilla-central/rev/58eca03214a6
BuildID   20140228040203
Version   30.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013

Comment 35

[Noemí Freire (:noemi)]

Hi John,

Could you please help us with the uplift to v1.3 branch?. Thanks!

Comment 36

[Ryan VanderMeulen [:RyanVM]]

v1.3: 1b92621f76d2cbbc1516be62d519d0b6d1c4bfdc