956393 - [Search] Suggestions results are cleared unexpectedly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

Suggestion results are being cleared. I think this is happening because we call .clear() for all messages (not just suggestion requests).

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Pull Request, Follow-up (Testing)

Also going to take this opportunity to add tests.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8355637 [details] [review]
Pull Request, Follow-up (Testing)

Hi Dale, Amir - This is essentially a very small patch, but I did add a lot of unit tests because I wanted this app to be well tested. If one of you could take a quick look - maybe skim over the tests it would be appreciated. Thanks!

Comment 3

[Amir Nissim (:amirn)]

Comment on attachment 8355637 [details] [review]
Pull Request, Follow-up (Testing)

r+ for the 'clearing results' bugfix, but I am not comfortable reviewing the tests since I'm not familiar with sinon.js

I guess green Travis means the everything is OK, but I would prefer we split the tests to a new bug.

Thanks.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8355637 [details] [review]
Pull Request, Follow-up (Testing)

I think you taking a look is good enough for me, but I will probably split up the commits to be safe. Thanks!

Comment 5

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 6

[Kevin Grandon :kgrandon]

Landed first part: https://github.com/mozilla-b2g/gaia/commit/09a18d35acee47e627ecf9a57ee608fae326bc48

Comment 7

[Kevin Grandon :kgrandon]

Landed tests: https://github.com/mozilla-b2g/gaia/commit/00c1426b61237bbdfa9f76eb33decaad9d2110ae