956417 - JavaScript Error: "uncaught exception: Can't find method getMCC" results in a blank screen during app purchase

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[krupa raj[:krupa]]

Attachment: timestamp: 01-03 22:05:16.722

Samsung tablet/Android version:4.0.4
Firefox Nightly 29.0a1 (2014-01-02)

steps to reproduce:
1. Install the add-on (https://addons.mozilla.org/en-US/firefox/addon/dev-marketplace/?src=search) to enable payments on your android tablet
2. Load https://marketplace.allizom.org on your firefox mobile
3. Search for a paid app
4. Start the purchase of that paid app
5. Log in using Persona

expected behavior:
PIN screen loads

observed behavior:
Webpay loads a blank screen. See attached screenshot

logcat shows
01-03 22:05:16.722 E/GeckoConsole( 4558): [JavaScript Error: "uncaught exception: Can't find method getMCC"]
01-03 22:05:16.732 W/System.err( 4558): java.lang.NoSuchMethodError: no static method with name='getMCC' signature='()I' in class Lorg/mozilla/gecko/GeckoNetworkManager;
01-03 22:05:16.742 W/System.err( 4558): 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
01-03 22:05:16.742 W/System.err( 4558): 	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:375)
01-03 22:05:16.742 W/System.err( 4558): 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:177)
01-03 22:05:16.752 E/GeckoConsole( 4558): [tracking] Setting

This error is blocking testing of payments on Android

Comment 1

[krupa raj[:krupa]]

Attachment: screenshot

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch v1

I think proguard might be removing these methods? They're only accessed via js-ctypes (aka jni). Seems to work with this fix.

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8359391 [details] [diff] [review]
Patch v1

I'm worried there's more unannotated JNI hiding throughout our code that we haven't found yet. Other than waiting for errors to crop up, I'm not sure how to hunt them down though...

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/e512dcbdb0d9

Comment 5

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/mozilla-central/rev/e512dcbdb0d9