957122 - Enable more TBPL tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Zac C (:zac)]

There are a few more new tests that can be enabled on TBPL.

You'll have to go through and work out which ones can be enabled and then enable them in tbpl-manifest.ini

Then once merged, watch TBPL and make sure they pass. 

Be prepared to back out the patch if they fail on TBPL.

Comment 1

[Bob Silverberg [:bsilverberg]]

Attachment: Add/enable two tests for Calendar app on TBPL

Whoever merges this needs to watch TBPL to make sure that Gu is still green.

Comment 2

[Bob Silverberg [:bsilverberg]]

Note that I am going to submit a number of separate PRs for tests that I find that can be enabled to make backing out simpler if there is a failure.

Comment 3

[Bob Silverberg [:bsilverberg]]

Attachment: PR for a new Gallery test on TBPL and also enabling it on Travis

Please watch Gu on TBPL after merging to ensure the test passes.

Comment 4

[Viorela Ioia [:viorela]]

Comment on attachment 8359445 [details] [review]
PR for a new Gallery test on TBPL and also enabling it on Travis

See comments in the PR

Comment 5

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8359445 [details] [review]
PR for a new Gallery test on TBPL and also enabling it on Travis

This won't work currently.

Comment 6

[Bob Silverberg [:bsilverberg]]

Attachment: Pull request to add 2 keyboard tests

Please watch the Gu component on TBPL after merging to ensure the tests pass.

Comment 7

[Bob Silverberg [:bsilverberg]]

Attachment: Enable test_lockscreen_wake_with_notification on TBPL

Please watch Gu on TBPL after merging.

Comment 8

[Bob Silverberg [:bsilverberg]]

Attachment: Enable test_sms_add_contact and test_sms_to_settings on TBPL

Please watch Gu on TBPL after merging.

Comment 9

[Bob Silverberg [:bsilverberg]]

Attachment: Enable test_settings_app_permissions on TBPL

Please watch Gu on TBPL after merging.

Comment 10

[Bob Silverberg [:bsilverberg]]

Attachment: Enable test_context_menu_activity_picker on TBPL

Please watch the Gu component on TBPL after merging.

Comment 11

[Bob Silverberg [:bsilverberg]]

Attachment: Enable test_prefs on TBPL

Please watch Gu on TBPL after merging

Comment 12

[Bob Silverberg [:bsilverberg]]

I have finished reviewing the existing tests for candidates to be run on TBPL. Once all of the above patches are merged and/or rejected this bug can be closed.

Comment 13

[Trif Andrei-Alin[:AlinT]]

Comment on attachment 8359438 [details] [review]
Add/enable two tests for Calendar app on TBPL

r+
Merged in:
https://github.com/mozilla-b2g/gaia/commit/f3a54267320cc063215d01fad7deb1a6c891b27d

Comment 14

[Trif Andrei-Alin[:AlinT]]

Comment on attachment 8359793 [details] [review]
Pull request to add 2 keyboard tests

r+
Merged in:
https://github.com/mozilla-b2g/gaia/commit/98f4e82b193d0f625c4a7dccc65e32782ecfaf4e

Comment 15

[Florin Strugariu [:Bebe]]

Comment on attachment 8359793 [details] [review]
Pull request to add 2 keyboard tests

This looks OK
https://tbpl.mozilla.org/php/getParsedLog.php?id=33026986&tree=B2g-Inbound

https://hg.mozilla.org/integration/b2g-inbound/rev/86456eb2d41f

Comment 16

[Florin Strugariu [:Bebe]]

Comment on attachment 8359438 [details] [review]
Add/enable two tests for Calendar app on TBPL

This looks OK

https://tbpl.mozilla.org/php/getParsedLog.php?id=33020893&tree=B2g-Inbound

https://hg.mozilla.org/integration/b2g-inbound/rev/6629fbcc4dc4

Comment 17

[Trif Andrei-Alin[:AlinT]]

Comment on attachment 8359968 [details] [review]
Enable test_prefs on TBPL

r+
merged in:
https://github.com/mozilla-b2g/gaia/commit/1307a485358cf8f7db6e92ae563d169b4e4c98e1

Comment 18

[Trif Andrei-Alin[:AlinT]]

Comment on attachment 8359802 [details] [review]
Enable test_sms_add_contact and test_sms_to_settings on TBPL

r+
merged in:
https://github.com/mozilla-b2g/gaia/commit/c8f2c2a666c3cdcae2f241fa0dfbcc13c494d1f6

Comment 19

[Zac C (:zac)]

Now bug 891882 is resolved we can enable even more TBPL tests :)

Comment 20

[Florin Strugariu [:Bebe]]

Comment on attachment 8359798 [details] [review]
Enable test_lockscreen_wake_with_notification on TBPL

Can you fix the merge conflicts

Comment 21

[Florin Strugariu [:Bebe]]

Comment on attachment 8359962 [details] [review]
Enable test_settings_app_permissions on TBPL

merge conflicts

Comment 22

[Florin Strugariu [:Bebe]]

Comment on attachment 8359964 [details] [review]
Enable test_context_menu_activity_picker on TBPL

LGTM

I will merge this and fallow the results on TBPL

Comment 23

[Florin Strugariu [:Bebe]]

Comment on attachment 8359964 [details] [review]
Enable test_context_menu_activity_picker on TBPL

Merged in 
https://github.com/mozilla-b2g/gaia/commit/5c72572eae59372de1498ad97ca7adcc9414e528

Comment 24

[Florin Strugariu [:Bebe]]

Comment on attachment 8359964 [details] [review]
Enable test_context_menu_activity_picker on TBPL

TBPL Pass:

https://tbpl.mozilla.org/php/getParsedLog.php?id=33101623&tree=B2g-Inbound

https://hg.mozilla.org/integration/b2g-inbound/rev/3f46d2861127

Comment 25

[Zac C (:zac)]

Comment on attachment 8359798 [details] [review]
Enable test_lockscreen_wake_with_notification on TBPL

r+

and Merged:
https://github.com/mozilla-b2g/gaia/commit/becb06a2d473def2233e87bc54d5431664517164

Comment 26

[Zac C (:zac)]

Comment on attachment 8359962 [details] [review]
Enable test_settings_app_permissions on TBPL

r+
and merged:
https://github.com/mozilla-b2g/gaia/commit/6d1872b8abd38afe73e6bd3ba32d47d104d0cbbd

Comment 27

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8359798 [details] [review]
Enable test_lockscreen_wake_with_notification on TBPL

Landed in https://github.com/bobsilverberg/gaia/commit/00e9b7e4dd772e84fdafebbf7a2f7ccd3f69f081

Comment 28

[Bob Silverberg [:bsilverberg]]

Oops, not only did I not need to add that comment, it also points at the wrong commit.  Ignore me. :(

Comment 29

[Bob Silverberg [:bsilverberg]]

All of the PRs I opened for this bug have been merged, so I'm going to mark this as fixed. Perhaps we should open another, or reopen this in a month or so to go through the exercise again? Although davehunt also mentioned that he'd like to get rid of the two-manifest system, which should remove the need to do this in the future.