957421 - Consider using consistent naming of FxA-specific configs

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[James Bonacci [:jbonacci]]

We have the following configs defined right now:
identity.fxaccounts.enabled
identity.fxaccounts.auth.uri
firefox.accounts.remoteUrl
identity.fxaccounts.auth.uri

And for sync (among many others):
services.sync.tokenServerURI
services.sync.clusterURL


If we are going to keep "firefox.accounts.remoteUrl", consider changing it to "identity.fxaccounts.remoteUrl" so that it is easier to find.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-957421-Keep-FxA-pref-names-consistent.patch

This patch renames firefox.accounts.remoteUrl to identity.fxaccounts.remote.uri.

Asking Mark for review of the browser parts and Nick for the Android parts.

This patch only changes the pref names for browser/base/content/test/general/browser_aboutAccounts.js but I also converted line endings from CRLF to LF.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8362933 [details] [diff] [review]
0001-Bug-957421-Keep-FxA-pref-names-consistent.patch

Oh, and Richard for the services stuff I guess :)

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8362933 [details] [diff] [review]
0001-Bug-957421-Keep-FxA-pref-names-consistent.patch

Review of attachment 8362933 [details] [diff] [review]:
-----------------------------------------------------------------

r+ for me.  Android about:accounts is going the way of the dodo soon.

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 8362933 [details] [diff] [review]
0001-Bug-957421-Keep-FxA-pref-names-consistent.patch

Review of attachment 8362933 [details] [diff] [review]:
-----------------------------------------------------------------

Note for someone motivated: these prefs should really be documented on a wiki page somewhere, so that we have some docs to get stale and mislead others.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8362933 [details] [diff] [review]
0001-Bug-957421-Keep-FxA-pref-names-consistent.patch

Review of attachment 8362933 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay!

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/088a4bf454a9

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/088a4bf454a9