Closed
Bug 957857
Opened 10 years ago
Closed 10 years ago
Preloading contacts in a SIM customization does not work anymore
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-b2g:1.3+)
RESOLVED
INVALID
blocking-b2g | 1.3+ |
People
(Reporter: jsmith, Assigned: albert)
Details
(Keywords: regression)
Build - 1/8/2014 Buri 1.3 STR 1. Follow the steps here - https://wiki.mozilla.org/B2G/QA/Customizations#Build_Setup to setup your customized build with an AT&T US SIM 2. After completing the FTE, launch the contacts app Expected There should be four contacts present - test 1, test 2, 310410 person, and Inf 310410. Actual There is only two contacts present - test 1, test 2. This implies that the SIM customized contacts failed to be preloaded.
Reporter | ||
Updated•10 years ago
|
blocking-b2g: --- → 1.3?
Keywords: regression
Comment 2•10 years ago
|
||
hi Yuren, wonder if you have some insight into this? Thanks
Flags: needinfo?(yurenju.mozilla)
Comment 3•10 years ago
|
||
Is there anything about contacts in the logcat?
Assignee | ||
Comment 4•10 years ago
|
||
I think this bug and 957866 are caused by bug 952922, I will review build dependencies.
Comment 5•10 years ago
|
||
This is a part of customization mechanism of variant.json. Albert, could you help on this issue?
Flags: needinfo?(yurenju.mozilla) → needinfo?(acperez)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → acperez
Flags: needinfo?(acperez)
Assignee | ||
Comment 6•10 years ago
|
||
From logcat: E/GeckoConsole( 1401): [JavaScript Error: "TypeError: 'type' member of ContactField can't be converted to a sequence." {file: "app://communications.gaiamobile.org/ftu/js/customizers/default_contacts_customizer.js" line: 7}] Error when creating contact -> var contact = new mozContact(contacts[i]); The format of attus_contacts.json is wrong, the attribute 'type' should be an array instead of string. Modifying "type": "Other" by "type": ["Other"] fix the problem.
Assignee | ||
Comment 7•10 years ago
|
||
Can you modify https://github.com/mozilla/qa-testcase-data/blob/gh-pages/customization/reference/attus/attus_contacts.json and https://github.com/mozilla/qa-testcase-data/blob/gh-pages/customization/reference/tmobileus/tmobileus_contacts.json ?
Flags: needinfo?(jsmith)
Reporter | ||
Comment 8•10 years ago
|
||
(In reply to Albert [:albert] from comment #6) > From logcat: > > E/GeckoConsole( 1401): [JavaScript Error: "TypeError: 'type' member of > ContactField can't be converted to a sequence." {file: > "app://communications.gaiamobile.org/ftu/js/customizers/ > default_contacts_customizer.js" line: 7}] > > Error when creating contact -> var contact = new mozContact(contacts[i]); > > > The format of attus_contacts.json is wrong, the attribute 'type' should be > an array instead of string. > Modifying "type": "Other" by "type": ["Other"] fix the problem. That's not right. This is exact format worked fine on 1.2, so this is a regression in format parsing on 1.3.
Flags: needinfo?(jsmith)
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #8) > (In reply to Albert [:albert] from comment #6) > > From logcat: > > > > E/GeckoConsole( 1401): [JavaScript Error: "TypeError: 'type' member of > > ContactField can't be converted to a sequence." {file: > > "app://communications.gaiamobile.org/ftu/js/customizers/ > > default_contacts_customizer.js" line: 7}] > > > > Error when creating contact -> var contact = new mozContact(contacts[i]); > > > > > > The format of attus_contacts.json is wrong, the attribute 'type' should be > > an array instead of string. > > Modifying "type": "Other" by "type": ["Other"] fix the problem. > > That's not right. This is exact format worked fine on 1.2, so this is a > regression in format parsing on 1.3. Anyway, is not a problem of single variant, the problem is with contacts API.
Reporter | ||
Comment 10•10 years ago
|
||
Reuben - Was the syntax change in the Contacts API intentional above?
Flags: needinfo?(reuben.bmo)
Comment 11•10 years ago
|
||
Yes. 'type' was always an array, but we only started enforcing it on 1.3 :(
Flags: needinfo?(reuben.bmo)
Reporter | ||
Comment 12•10 years ago
|
||
Okay - that makes this invalid then. I just patched the customization to use an array instead.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•