958314 - Popcorn remix will not play

Status: VERIFIED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[julia]

1. I am having trouble with this popcorn video:
https://popcorn.webmaker.org/templates/basic/?savedDataUrl=tour.json

I have renamed it and saved it several times, but it will not play back in any of these published links

https://juliavallera.makes.org/popcorn/1ong
https://juliahivenyc.makes.org/popcorn/1onm
https://juliahivenyc.makes.org/popcorn/1ona

2. also this popcorn tutorial is not playing
https://mozteach.makes.org/popcorn/1boj

but the content seems to be there when you click the remix button
https://popcorn.webmaker.org/editor/61795/remix

I tried to rename it and re-save it...the new link will not play
https://juliahivenyc.makes.org/popcorn/1onn

Comment 1

[Matthew Schranz [:mjschranz]]

Hey Julia,

We were having problems related to Vimeo and it looks like the cause of the problems there is the same thing your seeing here.

I tried this out locally which we have a fix for it and thankfully this seems to be fixed. I pushed that code up to our staging server just now. Can you check if https://popcorn.mofostaging.net/templates/basic/?savedDataUrl=tour.json has any issues for you? Try in a few minutes after reading this because it's literally in the process of building :)

Comment 2

[Chris DeCairos (:cade)]

the media in this project is HTML5, not Vimeo - I see:

TypeError: type is undefined embed.js:13773

in the console.

Comment 3

[Chris DeCairos (:cade)]

(In reply to Chris DeCairos (:cade) from comment #2)
> the media in this project is HTML5, not Vimeo - I see:

link was: https://juliavallera.makes.org/popcorn/1ong

Comment 4

[Matthew Schranz [:mjschranz]]

I am aware of that Chris. The patch I am speaking off touches more than Vineo and it fixes this problem from my own testing. I'm on a bus right now and will check in later.

Comment 5

[julia]

I can see the stage and content here: https://popcorn.mofostaging.net/templates/basic/?savedDataUrl=tour.json but when I sign on to save with persona it is asking me to create a new makes.org account name. It doesn't seem to link to my juliahivenyc account that already exists, so I cannot save and try the new link.

Comment 6

[Matthew Schranz [:mjschranz]]

That's to be expected Julia. Our staging servers are different environments so it doesn't mirror the data you have on our production servers. It's mostly a testing ground. You should be able to create an account with the same name and everything that will work but will point to something that is our staging equivalent of makes.org

Comment 7

[julia]

Ah, I see. Thank you. I saved it and republished, but the video still is not playing:
https://juliahivenyc.mywebmaker.org/popcorn/14jz

Comment 8

[Scott [:thecount] Downe]

Yeah, confirmed this is broken.

I think while similar, this is not the same as the Vimeo issue.

I think there is a chance here that broke us.

I could be missing it but we don't even have a check for html5, and why would we, there is no way to tell. We always just assumed it was html5 if it failed all the checks.

Comment 9

[Scott [:thecount] Downe]

bug 945373 broke this.

Shouldn't be hard.

Comment 10

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/408

This also broke sequence editors that were html5. The fallback input was no longer being displayed.

I think it's safe to return this still. I only removed it because it technically wasn't html5 and did one check that needs to worry about audio or images too, but that check is simply an } else { and can ignore the html5 part.

Comment 11

[Scott [:thecount] Downe]

Julia, thanks for bringing this to our attention. Huge help. I have a fix and should be landed shortly. I'll update this ticket and let you know when it is fixed and on popcorn.webmaker.org. It is reasonable to expect it done tomorrow around noon.

Comment 12

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/1d1b17398d2c4eb455c4591e475c81edaabec1eb

Needs verification.

Not on popcorn.webmaker.org yet.

Comment 13

[Scott [:thecount] Downe]

Should be working now on popcorn.webmaker.org