958533 - Add b2g desktop to the reftest sandbox

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Andrew Halberstadt [:ahal]]

We need a way to disable reftests for the b2g desktop platform only.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - add b2g desktop to reftest sandbox

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Why isn't this covered by the existing B2G property?

Comment 3

[Andrew Halberstadt [:ahal]]

Because b2g desktop's toolkit isn't gonk (it's gtk2 or cocoa depending on platform). I was thinking of doing something like:
B2G = appInfo.name == "b2g"
B2GRemote = B2G && toolkit == "gonk"
B2GDesktop = B2G && toolkit != "gonk"

But if people are used to disabling emulator tests with "B2G" they could accidentally and unknowingly disable b2g desktop tests as well.

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8358509 [details] [diff] [review]
Patch 1.0 - add b2g desktop to reftest sandbox

Review of attachment 8358509 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, unless dbaron has a different preference.

Comment 5

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1435517d890c

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1435517d890c