Closed
Bug 95857
Opened 23 years ago
Closed 23 years ago
process_bug.cgi sees blank address in cc: list (__UNKNOWN__)
Categories
(Bugzilla :: Bugzilla-General, defect, P1)
Bugzilla
Bugzilla-General
Tracking
()
RESOLVED
FIXED
Bugzilla 2.14
People
(Reporter: myk, Assigned: myk)
Details
(Keywords: regression)
Attachments
(5 files)
937 bytes,
patch
|
Details | Diff | Splinter Review | |
1.04 KB,
patch
|
Details | Diff | Splinter Review | |
1.07 KB,
patch
|
Details | Diff | Splinter Review | |
1.07 KB,
patch
|
Details | Diff | Splinter Review | |
1.07 KB,
patch
|
Details | Diff | Splinter Review |
process_bug.cgi appears to be parsing the cc: list such that it thinks the user submitting changes has entered a user with a blank email address into cc: field. Apparently this is triggered if the user enters two commas in a row into the cc: list field, although some users claim that it happened when they didn't do that. Bug 95798 exacerbates this problem, as does the presence of a user on b.m.o. with a blank login name (email address). The following bugs are currently affected: bug 87976 bug 82305 bug 21344 bug 92839 bug 95457 bug 95822 bug 72781 bug 95849
Assignee | ||
Comment 1•23 years ago
|
||
I don't want to disable the user's account (#12852) and give them a fake email address or integrate a fix for bug 95798 until we figure out what is causing this.
Updated•23 years ago
|
Assignee | ||
Comment 2•23 years ago
|
||
simplifying summary and adding __UNKNOWN__ to it so people find it more easily
Summary: process_bug.cgi looks for user with empty address in cc: list → process_bug.cgi sees blank address in cc: list (__UNKNOWN__)
Assignee | ||
Comment 3•23 years ago
|
||
The problem is in code that was fixed by Jake's patch to bug 95747. This is the old code: my @new = split(/[ ,]/, $cc_add); foreach my $person (@new) { This is the new code: foreach my $person (split(/[ ,]/, $cc_remove)) { # Ignore blanks next unless $person;
Assignee | ||
Comment 4•23 years ago
|
||
Assignee | ||
Comment 5•23 years ago
|
||
Although the bug has been fixed by a previous patch, the patch I just attached is a more compact and robust solution to the problem.
Assignee | ||
Comment 6•23 years ago
|
||
Comment 7•23 years ago
|
||
r= justdave committed
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 8•23 years ago
|
||
After talking in irc, we came up with a slightly better solution. REOPENing
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 9•23 years ago
|
||
Comment 10•23 years ago
|
||
Comment 11•23 years ago
|
||
Assignee | ||
Comment 12•23 years ago
|
||
works. r=myk
Comment 13•23 years ago
|
||
It's in. (I'm just glad we didn't need a Return of the Bugfixer :)
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Updated•23 years ago
|
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
Version: Bugzilla 2.13 → unspecified
Comment 14•23 years ago
|
||
Moving to Bugzilla product
Updated•11 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•