Closed Bug 95873 Opened 23 years ago Closed 23 years ago

Crash deleting certs under "Your Certificates" (cert manager)

Categories

(Core :: Layout, defect, P1)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
VERIFIED DUPLICATE of bug 97664

People

(Reporter: ckritzer, Assigned: kmcclusk)

References

Details

(Keywords: crash) 

1) Open Certificate Manager (Edit:Prefs:Privacy and
Security:Certificates:[Manage Certificate...]
2) Select a cert under "Your Certificates" and click the [Delete] button.
3) Click the [OK] button on the "Delete your Certificates" dialogue

For Win98SE, effectively clicking [OK] is the same as clicking [Cancel]. 
Unfortunately, on LinRH62, MacOS_X & MacOS91, the app crashes.

Marking NS Confidential.  If I'm wrong, please change it.
This bug blocks 87361 - I need to delete my certificates in my cert database so
I can test just the iButton.
Blocks: 87361
Group: netscapeconfidential?
->ddrinan for triage.
Chris, Regarding this bug blocking 87361, can't you use a fresh profile?
Assignee: ssaux → ddrinan
Priority: -- → P1
Target Milestone: --- → 2.1
-> rangansen
Assignee: ddrinan → rangansen
Adding roc+moz@cs.cmu.edu to the cc-list to see if he can shed some light on 
this crash.

Here is a stack trace of the crash. It's not in PSM code but in 
mozilla/view/src/nsViewManager.

nsViewManager::ProcessPendingUpdates(nsIView * 0x00000000) line 1635 + 7 bytes
nsViewManager::FlushPendingInvalidates(nsViewManager * const 0x067b5d00) line 
3827
nsViewManager::ProcessInvalidateEvent() line 3835
nsInvalidateEvent::HandleEvent() line 141
HandlePLEvent(nsInvalidateEvent * 0x06804b70) line 155
PL_HandleEvent(PLEvent * 0x06804b70) line 590 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x066ae290) line 520 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x00cd06ec, unsigned int 49446, unsigned int 0, 
long 107668112) line 1071 + 9 bytes
USER32! 77e71820()
066ae290()

It looks like mRootView is null, probably because the view was destroyed before
the invalidate was processed. But in that case we should have revoked the
outstanding InvalidateEvent. So, no obvious culprit.
marking nsenterprise, crash.
This must be fixed for 0.9.4
Robert, should I reassign this bug to the layout component?
Keywords: crash, nsenterprise
Including Kevin McCluskey in the cc list - Kevin is the owner of the Clipping
and Compositing module  [as per mozilla listing] which includes the
nsViewManager.cpp file; and he might be able to throw some light on what can be
done about this...
Reassigning this bug to the Clipping and Compositing - that is where this crash
is happening. It happens because of nsViewManager::ProcessPendingUpdates getting
a null nsView handle, and does not seem to be triggered in the PSM code.
Copying Stephane as well, for his comments 


Reassigning to browser->layout - that seems to be the nearest match
Assignee: rangansen → karnaze
Component: Client Library → Layout
Product: PSM → Browser
QA Contact: ckritzer → petersen
Target Milestone: 2.1 → M1
Version: 2.1 → other
adding nsenterprise+
Keywords: nsenterprise → nsenterprise+
adding myself to the cc list
Reassigning to kmcclusk.
Assignee: karnaze → kmcclusk
*** Bug 98282 has been marked as a duplicate of this bug. ***
Marking nsbranch+
Status: NEW → ASSIGNED
Keywords: nsbranch → nsbranch+
cc'ing Terry Hayes
Kevin:
Here's a reproducible test case:
Create a new profile.
start on new profile.
pref->priv & sec->Master Passwords->change password (enter a non-empty pwd)
pref->priv & sec->certificates->manage certs->restore (restore a cert from a p12)

At this point you have a cert in your cert db, and your cert db has a pwd.

Exit.
Start on same profile.
Tasks->Priv & sec->Pwd manager->logout (you get some dialog)
Prefs->priv & sec->certificates->manage certs. Select a cert and delete, click
ok on resulting dialog and crash.

Look me up in phonebook if you need help.



*** This bug has been marked as a duplicate of 97664 ***
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
Verified dupe.
Status: RESOLVED → VERIFIED
verified that the simple test case involving a logout before the delete
operation doesn't result in a crash anymore.  Instead the Master pwd is
requested and after providing it the cert is deleted, which is exactly what
would be expected.
You need to log in before you can comment on or make changes to this bug.