958778 - De-holder nsIXPConnect::GetWrappedNativePrototype()

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Andrew McCreight [:mccr8]]

Once WrapNative is cleared up, that leaves GetWrappedNativePrototype, CreateSandbox and InitClassesWithNewWrappedGlobal.  HoldObject gets left behind as a shim for places that use holders on the heap.  I think that will work out okay.

Comment 1

[Andrew McCreight [:mccr8]]

Filing separate bugs for each part.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: De-holder nsIXPConnect::GetWrappedNativePrototype().

Again, this can wait for a few weeks. This one is a lot smaller than the other one.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2952db5b7e8

Comment 3

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8624955 [details] [diff] [review]
De-holder nsIXPConnect::GetWrappedNativePrototype().

Review of attachment 8624955 [details] [diff] [review]:
-----------------------------------------------------------------

Same comment about the |in JSMutableHandleObject aRetVal|. If what I suggested does not work out for some reason I'm fine with whatever Bobby or Boris suggests in this case.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: De-holder nsIXPConnect::GetWrappedNativePrototype().

static analysis try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b11ac68ad31

Comment 5

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8628003 [details] [diff] [review]
De-holder nsIXPConnect::GetWrappedNativePrototype().

Review of attachment 8628003 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry I overlooked this one.

::: js/xpconnect/idl/nsIXPConnect.idl
@@ +262,5 @@
>  // For use with the service manager
>  // {CB6593E0-F9B2-11d2-BDD6-000064657374}
>  #define NS_XPCONNECT_CID \
> +{ 0xb91f1eeb, 0x2fe4, 0x44cc, \
> +  { 0x99, 0x83, 0xab, 0xcc, 0x06, 0xd6, 0x9a, 0x94 } }

You don't have to change the CID only the uuid of the interface.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a3dfde50685

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3a3dfde50685