958797 - Give functions gotten from the Function constructor scripted function types.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Shu-yu Guo [:shu]]

We apparently never set the type of Function constructor'd functions to be
scripted function types, meaning they aren't inlined.

This is a result of debugging the slowdown from
http://jsperf.com/function-vs-constructor-vs-eval/19, which bz showed me.

Comment 1

[Shu-yu Guo [:shu]]

Attachment: Give functions gotten from the Function constructor scripted function types.

Is this a regression? I didn't check, maybe we used to do this and somewhere it
got deleted?

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8358740 [details] [diff] [review]
Give functions gotten from the Function constructor scripted function types.

Review of attachment 8358740 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh, nice catch.

::: js/src/jsfun.cpp
@@ +1658,5 @@
>                                                  JSFunction::FinalizeKind, TenuredObject));
>      if (!fun)
>          return false;
>  
> +    if (!JSFunction::setTypeForScriptedFunction(cx, fun, /* singleton = */ false))

Nit: the last argument defaults to false so you could remove it; either way is fine with me.

Comment 3

[Shu-yu Guo [:shu]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf8de5ab6d04

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bf8de5ab6d04