959147 - Search Results Overlay Minimum Results has Two Blank Tiles

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: General, defect, P2)

Description

[Stephen Horlander [:shorlander]]

Not sure if this is intentional but if you only have one search result you end up with two placeholder tiles that you can't click.

Comment 1

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: 959147.patch

By default we have 3 empty slots for new grids, which includes the search results grid. They were hidden by default, but the fix for bug 941284 regressed this, making the search empty slots visible.

Comment 2

[Rodrigo Silveira [:rsilveira] [:rodms]]

p=1

Comment 3

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8359523 [details] [diff] [review]
959147.patch

Review of attachment 8359523 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me.

Comment 4

[Rodrigo Silveira [:rsilveira] [:rodms]]

https://hg.mozilla.org/integration/fx-team/rev/6f92e4a555b1

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6f92e4a555b1

Comment 6

[Manuela Muntean [Away]]

Please give some guidance in order for the QA to verify this. Thanks!

Comment 7

[Rodrigo Silveira [:rsilveira] [:rodms]]

For QA: Without the patch when you type on the url bar and autocomplete has only one result, 3 tiles would show up. 2 of them blank. With this fix only the result tile shows up. To test this type in the name of a site that has only 1 entry in bookmarks/history.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/509aafb4f3b2

Comment 9

[Manuela Muntean [Away]]

Attachment: screenshot.png

>For QA: Without the patch when you type on the url bar and autocomplete has only >one result, 3 tiles would show up. 2 of them blank. With this fix only the result >tile shows up. To test this type in the name of a site that has only 1 entry in >bookmarks/history.

With a new profile and latest Nightly on Win 8 64-bit, I can see 3 tiles showing up for a site that has only 1 entry in History section. (please see the attached screenshot for details)

Any suggestions?

Comment 10

[Rodrigo Silveira [:rsilveira] [:rodms]]

The screenshot seem to show 3 actual results. You can type 'involved' on a brand new profile. It should show you only the 'get involved' default bookmark tile. The bug was about showing empty tiles when you had less than 3 results, if you're seeing clickable tiles it's expected.

Comment 11

[Manuela Muntean [Away]]

Attachment: screenshots.zip

Please see the attached screenshots:

- on Win 8 64-bit with latest Nightly and a new profile:

1) "nightly_first search.png" shows the results of the first search performed

2) "nightly_second search.png" shows the results of the second, third, etc. searches performed

Is this intended?

Comment 12

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Autocomplete1Result.png

This is what I'm seeing. I think the two results you're seeing are because once you visit the default bookmarked site you may get redirected and end up with a another match for "involved" in your history :(. One last think you can try is visiting a site with an odd name like http://9gag.com, then search for 9gag and you should see a single history entry.

Comment 13

[Manuela Muntean [Away]]

> One last think you can try is visiting a site with an odd name like http://9gag.com, then
> search for 9gag and you should see a single history entry.

Yes, indeed, this works. Verified as fixed, for iteration #22, with latest Nightly and Aurora on Win 8 64-bit.