Closed Bug 959396 Opened 10 years ago Closed 10 years ago

MetroFx sometimes gets into state where the pref "browser.sessionstore.resume_session_once" is stuck to "true"

Categories

(Firefox for Metro Graveyard :: Browser, defect, P2)

Product:
Firefox for Metro Graveyard
Component:
Browser
Platform:
x86_64
Windows 8.1
Type:
defect

Tracking

(firefox28 verified, firefox29 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 29
Tracking Flags:
Tracking Status
firefox28 --- verified
firefox29 --- verified

People

(Reporter: TimAbraldes, Assigned: emtwo)

References

Details

(Whiteboard: [beta28] [defect] p=3)

Attachments

(1 file, 1 obsolete file)

v2: Init WindowsPrefSync sooner and check populate _orderedWindows even when not restoring
5.35 KB, patch
TimAbraldes
: review+
Details | Diff | Splinter Review 
The pref "browser.sessionstore.resume_session_once" sometimes gets stuck to "true," causing metroFx to always restore its previous session.
Blocks: metrov1backlog
Whiteboard: [triage] → [triage] [defect] p=0
Whiteboard: [triage] [defect] p=0 → [beta28] [defect] p=0
Whiteboard: [beta28] [defect] p=0 → [beta28] [defect] p=3
So it turns out we were initializing WindowsPrefSync after we were setting resume_session_once to false here:

http://dxr.mozilla.org/mozilla-central/source/browser/metro/components/SessionStore.js#137

This meant the registry entry for resume_session_once was not updated to false and stuck as true.

After doing this, I also noticed I was getting the issue you came across before, Tim, where the sessionstore.js file was not written correctly. This was something I missed when I did bug 950159 related to setting the _orderedWindows property even when we are not restoring.
Assignee: nobody → msamuel
Status: NEW → ASSIGNED
Attachment #8362752 - Flags: review?(tabraldes)
Blocks: metrov1it23
No longer blocks: metrov1backlog
Priority: -- → P2
QA Contact: jbecerra
Oops that last patch was not up to date.
Attachment #8362752 - Attachment is obsolete: true
Attachment #8362752 - Flags: review?(tabraldes)
Attachment #8362770 - Flags: review?(tabraldes)
Comment on attachment 8362770 [details] [diff] [review]
v2: Init WindowsPrefSync sooner and check populate _orderedWindows even when not restoring

Review of attachment 8362770 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM though I haven't tested the fix locally
Attachment #8362770 - Flags: review?(tabraldes) → review+
https://hg.mozilla.org/integration/fx-team/rev/97b55e139fe1
Whiteboard: [beta28] [defect] p=3 → [fixed-in-fx-team][beta28] [defect] p=3
https://hg.mozilla.org/mozilla-central/rev/97b55e139fe1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][beta28] [defect] p=3 → [beta28] [defect] p=3
Target Milestone: --- → Firefox 29
Keywords: checkin-needed
Whiteboard: [beta28] [defect] p=3 → [beta28] [defect] [a=metro-only] p=3
https://hg.mozilla.org/releases/mozilla-aurora/rev/1cea3bc6f5a1
status-firefox28: --- → fixed
status-firefox29: --- → fixed
Keywords: checkin-needed
Whiteboard: [beta28] [defect] [a=metro-only] p=3 → [beta28] [defect] p=3
Kamil, can you please try to verify this is fixed in the latest Nightly and Aurora?
Flags: needinfo?(kamiljoz)
Keywords: verifyme
Verified as fixed, for iteration #23, with both latest Nightly and Aurora on Win 8.1 64-bit: the pref "browser.sessionstore.resume_session_once" doesn't get stuck to "true," .
Status: RESOLVED → VERIFIED
status-firefox28: fixed → verified
status-firefox29: fixed → verified
Keywords: verifyme
Flags: needinfo?(kamiljoz)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: