959491 - Landscape mode for data/time picker

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

From this card in trello, I found we have a design for landscape mode of date/time picker and the general value selector.
https://trello.com/c/KeY47a5X/94-ui-component-adaptation-for-landscape

However, need the confirmed visual design so that we could implement the landscape mode for these general control components.

Will open related bugs and make this a meta bug if there are too much work to do here.

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi Eric,

I heard from Patryk, that you could provide the detailed design for common controls?
Let me know if I should redirect this to someone else.
Thanks.

Comment 2

[Eric Pang [:epang] UX]

(In reply to Rudy Lu [:rudyl] from comment #1)
> Hi Eric,
> 
> I heard from Patryk, that you could provide the detailed design for common
> controls?
> Let me know if I should redirect this to someone else.
> Thanks.

Hi Rudy, what is the landscape date time picker for?  Which device, which apps?
AFAIK we don't use landscape mode for it on the phone.

Thanks!
Eric

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: screenshot for date picker in landscape mode

Hi Eric,

Since <input type="date"> or <input type="time"> is a common usage on web, and our browser app allows landscape mode, we could see this issue on plain web.

Please refer to the screenshot for an example.
Let me know if you have any other questions.

Comment 4

[Eric Pang [:epang] UX]

Attachment: Time_Picker.jpg

Hi Rudy, I looked on trello.  Can we use the specs that Sergi provided?

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi Eric,

Yes for sure if you think the design by Sergi is ok.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I guess the changes for this bug should be mostly CSS, so mark this as good first bug.

Comment 7

[Akshat Kedia [:aks]]

I am interested in working on this bug.  Can I be assigned to it ?

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi Akshat,

Sure.

Please note that the value selector we're talking about here lives in Gaia system app.
Please let me know if you need more guidance on how to resolve this issue.

Thanks.

Comment 9

[Akshat Kedia [:aks]]

https://developer.mozilla.org/en-US/Firefox_OS/Using_the_B2G_desktop_client
I dont have a Firefox OS phone. Can this be used for testing bugs and changes ?

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yes, and you could even use Firefox browser to run Gaia, so you will get all the developer tools working,
https://developer.mozilla.org/en-US/Firefox_OS/Using_Gaia_in_Firefox

BTW, after a 2nd thought, this might need some changes in JS as well, just a soft reminder.
Thanks.

Comment 11

[Akshat Kedia [:aks]]

Sorry for the late reply, I was super busy with university. Can you tell me which part of the codebase I need to work on. I can't find the date picker in gaia/apps/system.

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

For time picker, it is in,
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/value_selector/value_selector.js

For date picker, it is in the above and another separate file,
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/value_selector/spin_date_picker.js

Thanks for your interest.

Comment 13

[loganallc]

Hello there. I'm not sure if Akshat is still working on this bug, but if he is not, I would love to contribute.

Comment 14

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I am not sure, either. Let's ni him.

Akshat,

Are you still working on this?


--
Thanks for your interest in contributing to Firefox OS.

Comment 15

[Akshat Kedia [:aks]]

Hey,

I am sorry for not updating here. I am not really working on the bug right now. Anyone can go ahead with the bug.

Comment 16

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Akshat, thank you.

Then, I'll assign to loganallc since he is interested to take a look.

Comment 17

[Julio Leal]

Hi , can I help in this bug? I am new so I may need assistance!

Comment 18

[Sam Foster [:sfoster] (he/him)]

Julio, I'm flagging Rudy (the mentor for this bug - he has offered to provide assistance on this)

Comment 19

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

loganallc,

May I know if you're still working on this bug?
If not, maybe Julio could take a look.

Julio,

Thanks for your interest, let's see how loganallc responds.

Comment 20

[Radu-Bogdan Croitoru]

Hey guys,

Do you know if loganallc is working on this or I can take a look?

Thanks

Comment 21

[Mike Hoye [:mhoye]]

It doesn't look like Loganallc is still working on this; last touch from them was 2 months ago. 

I'm deassigning it. croitoruradubogdan - are you still interested in pursuing this? We'd love for you to pick it up.

Comment 22

[Radu-Bogdan Croitoru]

Sure, I wanna try to fix this :). Thanks Mike

Comment 23

[Mike Hoye [:mhoye]]

Great. Run with it, and if you've got any questions, ask them here. Rudy will be able to help.

Comment 24

[talhaanwar.anwar]

Anyone working on this bug?

Comment 25

[Bruno Lima]

Hi, I'm new here and would like to help fixing this bug. Rudy Lu please assign to me this bug.

Thanks!

Comment 26

[Radu-Bogdan Croitoru]

Hi, I was out of town and this bug was assigned to me 3 days ago. Can someone assign it so we can know who's working on it? It's not a contest..

Comment 27

[Bruno Lima]

Hi croitoruradubogdan, sorry, did not know that was assigned to you, because not in the description of the bug. Thank you for helping Mozilla community.

Comment 28

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Assign this to Radu-Bogdan based on comment 22.

Comment 29

[Pas]

Hi, I am new to fixing bugs and I would like to work on the bug please.

Comment 30

[Mike Hoye [:mhoye]]

Ok, Pas, we haven't seen any movement on this in a while so I'm going to reassign this to you. Let me know if you've got any questions, please use the "needinfo" checkbox at the bottom of the bug or email me directly.

Comment 31

[Pas]

Please where

Comment 32

[a2gm.tryouge]

Hi, I am new to bug fixing and this would be my first bug ever. I would like to work on this. Thanks.

Comment 33

[Syed Ali]

I'm a student from coventry university studying an opensource module, I would like to be assigned this as my first bug! Could you please point me in the right direction of how to start

Comment 34

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Not working on this anymore, and also not sure if this is still a good first bug, so clear the flag here.

Comment 35

[BMO Automation]

Firefox OS is not being worked on