Closed
Bug 959508
Opened 10 years ago
Closed 10 years ago
Remove EXTERNALLY_MANAGED_MAKE_FILE traversal
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla29
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
1.96 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
EXTERNALLY_MANAGED_MAKE_FILE traversal was used for gyp, but now gyp directories are handled as if they had a moz.build, so they don't need specific traversal rules. The exception in config.mk, however, is still needed for bug 952120 and config/tests/src-simple/Makefile.in.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8359653 -
Flags: review?(gps)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Vaguely recall a patch checked in that uses this for extension built with SeaMonkey (using mc build system. Cc to confirm
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Justin Wood (:Callek) from comment #2) > Vaguely recall a patch checked in that uses this for extension built with > SeaMonkey (using mc build system. Cc to confirm See comment 0, that was bug 952120, and it's not using what i'm removing.
Updated•10 years ago
|
Attachment #8359653 -
Flags: review?(gps) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b528de4b776f
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b528de4b776f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•10 years ago
|
Whiteboard: [qa-]
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•