959896 - Home banner icon loaded from chrome:// URI is too small

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

Attachment: patch that illustrates problem

This sounds similar to bug 921668, but I'm experiencing this issue with chrome:// URIs now.

This loosely blocks bug 958891 because I'd like to include that icon as a chrome URI, but I can always fall back to just using a data URI if needed.

wesj, do you know where along the line this might be going wrong?

Comment 1

[:Margaret Leibovic]

I don't know what code path we're following, but if we're going down this path, we're not passing in the resources anywhere:
http://hg.mozilla.org/mozilla-central/annotate/3a264db9f9e7/mobile/android/base/gfx/BitmapUtils.java#l73

Comment 2

[Wesley Johnston (:wesj)]

scaleType=center won't scale the image:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/home_banner.xml#32

centerCrop,fitCenter, or centerInside will http://developer.android.com/reference/android/widget/ImageView.ScaleType.html

Other than that, we should probably do some blog posts/write some utilities to help detect DPI and use it provide better/correct resolution resources from JS (as well as documenting the expected resolutions better).

Comment 3

[:Margaret Leibovic]

But how does that explain the difference between chrome:// URIs and data: URIs? I tried loading the same image as a data: URI, and that actually made it large as expected.

Comment 4

[:Margaret Leibovic]

I'm just going to use Android resources for bug 958891, so this doesn't block anymore, although it would still be good to investigate this bug at some point.

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.