Closed
Bug 959930
Opened 10 years ago
Closed 4 years ago
put log length on a new line
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: heycam, Assigned: heycam)
Details
(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2291] )
Attachments
(1 file, 1 obsolete file)
|
1.26 KB,
patch
|
catlee
:
review+
|
Details | Diff | Splinter Review |
The change to log length error message in bug 958327 made it awkward for sheriffs finding the generic "log length exceeded" bug on tbpl. philor suggested putting the amount the log was exceeded by on a new line, matching the existing regex so that it is included in the bug comment.
Attachment #8360201 -
Flags: review?(catlee)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8360201 [details] [diff] [review] patch You've got two parameters for string interpolation in the 2nd line, but only one value being passed in. Do you want something like "Output was %i bytes (exceeded limit by %i bytes)" % (self.nonHeaderLength, self.nonHeaderLength - self.logMaxSize) ?
Attachment #8360201 -
Flags: review?(catlee) → review-
|
Assignee | |
Comment 2•10 years ago
|
||
I did mean to put another value in there, yes. (No way for me to test locally obviously!) But the second line needs to begin with "Output exceeded ... bytes" so that the tbpl regexes pick it up.
Attachment #8360201 -
Attachment is obsolete: true
Attachment #8361352 -
Flags: review?(catlee)
|
|
||
Updated•10 years ago
|
Attachment #8361352 -
Flags: review?(catlee) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/build/buildbot/rev/56bbd2b06325
|
||
Updated•10 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2279]
|
|
||
Updated•10 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2279] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2288]
|
|
||
Updated•10 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2288] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2291]
|
||
Updated•7 years ago
|
Component: Tools → General
|
||
Comment 4•4 years ago
|
||
Both TBPL and Buildbot are now defunct. I think we can close this.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•