959948 - Drop unused forward-declarations and includes in layout/forms/nsI*Frame.h

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P4)

Description

[Daniel Holbert [:dholbert]]

While skimming some layout/forms classes for bug 101019, I noticed that the various nsI[XYZ]Frame.h interfaces there all have some unused forward decls (and a few unused #includes).

Filing this bug on dropping those.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

I verified that none of these classes are mentioned in the .h files in question, and I also verified that I can still compile with this patch applied (which effectively should mean that it's correct).

Comment 2

[Daniel Holbert [:dholbert]]

aside: I also noticed that the nsIComboboxControlFrame header-comment is blindly copied from nsIFormControlFrame, and as such, is 100% incorrect ("...is the common interface for frames of form controls...") :)

This has been the case since that file was first added to CVS back in January 1999:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/forms/nsIComboboxControlFrame.h&rev=1.1&root=/cvsroot

Tomorrow, I'll add a second patch here to make that comment slightly closer to reality.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v2 (now including comment-tweak)

Actually, I just folded that comment-fix into the existing patch.

Comment 4

[Daniel Holbert [:dholbert]]

Sanity-check try run, just in case we have some platform-specific file that implicitly depends on one of the decls/#includes that this patch removes:
 https://tbpl.mozilla.org/?tree=Try&rev=913fc369a8da

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87fd5e4568d6

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/87fd5e4568d6